Scope Bundler Audit to Dependabot Bundler PRs - #3041
Closed
goosys wants to merge 1 commit into
Closed
Conversation
Collaborator
|
I think we should disable bundler-audit altogether. This days fails more often than it succeeds, and seeing a failure won't alert us to anything any more. We will continue to merge dependabot PRs at the usual rate, so there's nothing to be gained. |
Member
|
Hm yeah, I agree. I've opened #3059 to just remove it. I'll close this. |
nickcharlton
added a commit
that referenced
this pull request
Aug 26, 2026
bundle audit isn't helping us that much, so having the CI status repeatedly failing isn't doing us any favours. We're using Dependabot to keep up with dependencies otherwise and this is adequate for this project. Previously talked about in #3041.
nickcharlton
added a commit
that referenced
this pull request
Aug 26, 2026
bundle audit isn't helping us that much, so having the CI status repeatedly failing isn't doing us any favours. We're using Dependabot to keep up with dependencies otherwise and this is adequate for this project. Previously talked about in #3041.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’m not sure we need to run this audit on every PR.
Would it make sense to limit it to Dependabot PRs only?
Also, since this workflow checks Bundler dependencies specifically, I additionally scoped it to Dependabot Bundler PRs (dependabot/bundler/*).
What do you think?