Wrap an error & some linting - #3603
Merged
Merged
Conversation
peterebden
commented
Sep 15, 2026
| return locals, nil | ||
| }) | ||
| pkgScope.Assert(err == nil, "failed to subinclude %s: %s", label, err) | ||
| pkgScope.Assert(err == nil, "failed to subinclude %s: %w", label, err) |
Collaborator
Author
There was a problem hiding this comment.
This is the main thing I actually wanted. It is a bit more important for output than it used to be that we can classify errors correctly
toastwaffle
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was hoping I could get golangci to check for this sort of thing, but turns out it isn't that smart. Oh well.
Also reformatted BUILD files because I got a message about it.