Add unit tests for vector operations#163
Open
jasveena15 wants to merge 1 commit intothoth-tech:mainfrom
Open
Conversation
222448082Ashen
approved these changes
May 2, 2026
222448082Ashen
left a comment
There was a problem hiding this comment.
I have reviewed the changes in unit_test_vector.cpp. The test coverage is comprehensive and follows the established project structure. The use of Approx for floating-point comparisons is a great addition for precision stability. This PR effectively improves the reliability of our core mathematics module. Approved.
kyriesk
approved these changes
May 7, 2026
kyriesk
left a comment
There was a problem hiding this comment.
I tested the unit_test_vector.cpp on my local machine using a WSL setup, and all tests passed without issues. The code follows SplashKit’s coding standards and behaves functional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a new vector unit test suite for SplashKit Core.
This PR introduces unit tests for core vector functionality in
unit_test_vector.cpp. The tests validate vector creation, vector arithmetic operations, vector properties, and helper utility functions.The following functionality is tested:
These tests improve confidence in the correctness and stability of SplashKit's vector mathematics functionality.
Type of change
How Has This Been Tested?
Tested by rebuilding the project and running both the interactive test application and automated unit test suites.
Commands used:
All tests passed successfully.
Testing Checklist
Checklist