upload-submission-modal: migrate modal service to uibModal#487
Open
sheshankarvapally wants to merge 1 commit intothoth-tech:10.0.xfrom
Open
upload-submission-modal: migrate modal service to uibModal#487sheshankarvapally wants to merge 1 commit intothoth-tech:10.0.xfrom
sheshankarvapally wants to merge 1 commit intothoth-tech:10.0.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrated the
upload-submission-modaldependency from the old AngularJS$modalservice to$uibModal.Investigation
The
upload-submission-modalmodule is still required because it controls the task submission workflow, including file/evidence upload, test submission handling, group contribution flow, comments, declaration display, and upload completion handling.The module should not be removed because task submissions still depend on this modal workflow.
The blocker identified was the old
$modaldependency used to open the submission modal.The template and SCSS files were reviewed as part of the ticket. However, they do not directly use the modal service, so they did not require changes for this dependency migration.
Migration
The migration was completed in
upload-submission-modal.coffee.The factory injection was updated from
$modalto$uibModal.The modal open call was updated from
$modal.opento$uibModal.open.The existing modal configuration was preserved, including:
taskvaluereuploadEvidencevalueThis keeps the migration small, focused, and safe, while removing the old modal service dependency from this module.
Changes Made
$modalservice injection with$uibModal.$modal.openwith$uibModal.open.Files Changed
src/app/tasks/modals/upload-submission-modal/upload-submission-modal.coffeeVerification
$modal.openis no longer used inupload-submission-modal.coffee.$modalInstancereferences are expected because they control the currently opened modal instance.