fix: re-add groups module registration to states.coffee and angularjs#486
fix: re-add groups module registration to states.coffee and angularjs#486Sujay-Deakin wants to merge 1 commit intothoth-tech:10.0.xfrom
Conversation
sakethsram8888
left a comment
There was a problem hiding this comment.
Reviewed and tested this locally in my dev container, the groups page renders correctly, "No Groupwork Enabled" state loads up fine with the Material icon and Unit Administration button showing as expected. No errors or issues on my end.
The migration is clean and well-scoped. The Angular control flow (@if/@else), Material icon swap, Tailwind replacements, and the hybrid downgrade registration are all done correctly. The old AngularJS controller and groups.tpl.html cleanup is exactly what we want to see for this kind of migration.
One minor thing, might be worth dropping a quick comment in the empty groups.component.scss just to make it clear the lack of styles is intentional.
Overall code is clean and error-free. can be approved from my end
Description
Migrates
units/states/groupsfrom CoffeeScript/AngularJS to TypeScript/Angularas part of the ongoing Angular migration effort.
Changes
groups.component.tswith@Input()bindings forunitandunitRolegroups.component.htmlreplacing oldgroups.tpl.html:ng-if/ng-hidewith Angular@if/@elsecontrol flowfa-usersicon with Angular Materialmat-iconui-srefwith Angular[uiSref]bindinggroups.component.scss(no custom styles needed)UnitGroupsStateComponentindoubtfire-angular.module.tsdoubtfire-angularjs.module.tsfor hybrid compatibilitygroups.coffeegroups.tpl.htmlTesting
units/1/students/groupsas a Convenordescription text, and Unit Administration button
Screenshots