add core progress indicator#479
Conversation
owens-hub-git
left a comment
There was a problem hiding this comment.
I can see that this works from your screenshots, but it feels out of place. When I say this I mean there is lot's of space around the core progress indicator and it lacks description. If I was a student looking at this I wouldn't know what it is or why it's important here.
Also, I'm unsure why you deleted comments because it gave developers an understanding of where parts of the ui are as they are not named but just divs.
Thanks for the feedback. I’ve updated the Core Progress Indicator to reduce the empty space, added clearer student-facing description text explaining why it is useful, and restored the structural comments in the dashboard template for developer readability. |
owens-hub-git
left a comment
There was a problem hiding this comment.
Testing this now, but you need to merge the commits to your own team branch not development which is then merged into 10.0.x by Brian
mudith-perera
left a comment
There was a problem hiding this comment.
Reviewed the work. Good job, Sanjana! I approve these changes.
Description
This pull request introduces a new
Core Progress Indicatorcomponent to the student progress dashboard by transitioning from static or implicit progress tracking to a fully dynamic, data-driven visualization powered by a backend API.Previously, students did not have a clear, consolidated view of their progress toward their selected target grade. This PR implements a structured progress calculation based on the student’s actual task completion data relative to the required tasks for their target grade. The system now provides a continuous and accurate representation of progress throughout the unit.
Additionally, this change enhances the user interface by introducing a clean and intuitive progress summary card featuring a visual progress bar, percentage indicator, and task completion breakdown, improving clarity and usability.
The change includes:
Implementing a new backend API endpoint:
GET /api/peer_progress/:unit_id/:student_idto dynamically calculate student progress based on:
Adding a new AngularJS directive
core-progress-indicatorto render progress data in the frontend.Replacing static or implicit progress representation with real-time API-driven data.
Implementing a responsive progress bar using dynamic width binding (ng-style) to visually represent progress percentage.
Displaying descriptive target grade labels returned by the backend API.
Updating
states.coffeeanddirectives.coffeeto register and load the new component.Updating
doubtfire-angularjs.module.tsto include the directive in theAngularJS bundling pipeline.Cleaning up redundant or conflicting dashboard layout elements during integration.
Matching backend PR: thoth-tech/doubtfire-api#98
This frontend PR depends on the matching doubtfire-api PR for: GET /api/peer_progress/:unit_id/:student_id
Fixes # (issue)
Type of change
How Has This Been Tested?
Test steps:
Testing Checklist:
Checklist: