Migrate Students List Component#478
Conversation
owens-hub-git
left a comment
There was a problem hiding this comment.
Overall this looks ok, some things I wanted to ask about:
-
I like the newer style, but I think the blue outline from before was fine and allowed some visual positives where you can see the bounds of the component
-
Are you considering the mobile views? I know most people won't be using it in that way but it shows a weird visual where it's off the screen, shown below:
millyamolo
left a comment
There was a problem hiding this comment.
I tested the PR locally and verified the migrated students-list component works as expected.
The new Angular/TypeScript implementation appears consistent with the existing app structure.
I did not find any regressions in the students list behavior during local testing.
The migration looks complete and ready to merge from my side. Approved
millyamolo
left a comment
There was a problem hiding this comment.
I tested the PR#478 locally and verified the migrated students-list component works as expected.
The new Angular/TypeScript implementation appears consistent with the existing app structure.
I did not find any regressions in the students list behavior during local testing.
The migration looks complete and ready to merge from my side. Approved
Thanks @owens-hub-git, I’ve addressed the mobile layout issue and restored the visual boundary styling. The component has been re-tested on both desktop and mobile views. |
owens-hub-git
left a comment
There was a problem hiding this comment.
I will approve here as it looks fine visually, I am concerned with the validity of the ts file that goes with it by the complexity difference between the original design

Description
This PR migrates the legacy
students-listview from AngularJS/CoffeeScript to Angular.Changes included
Removed legacy files:
students-list.coffeestudents-list.tpl.htmlstudents-list.scssAdded Angular component files:
students-list.component.tsstudents-list.component.htmlstudents-list.component.scssUpdated Angular module registration and state configuration
Removed legacy state references
Existing functionality retained
UI updates
Updated task progress indicators to improve visibility of student progress:
This keeps the original behaviour while improving readability.
Fixes # (ticket number)
Type of Change
Testing
Tested locally on
10.0.xVerified:
Before screenshots

After screenshots

Testing Checklist
Checklist