Skip to content

Migrate Students List Component#478

Open
WaelAlahamdi wants to merge 2 commits intothoth-tech:10.0.xfrom
WaelAlahamdi:migrate-students-list
Open

Migrate Students List Component#478
WaelAlahamdi wants to merge 2 commits intothoth-tech:10.0.xfrom
WaelAlahamdi:migrate-students-list

Conversation

@WaelAlahamdi
Copy link
Copy Markdown

Description

This PR migrates the legacy students-list view from AngularJS/CoffeeScript to Angular.

Changes included

  • Removed legacy files:

    • students-list.coffee
    • students-list.tpl.html
    • students-list.scss
  • Added Angular component files:

    • students-list.component.ts
    • students-list.component.html
    • students-list.component.scss
  • Updated Angular module registration and state configuration

  • Removed legacy state references

Existing functionality retained

  • Student search and autocomplete
  • Advanced filters
  • Sorting
  • Pagination
  • CSV export
  • Enrol student modal
  • Navigation to student profile/dashboard

UI updates

Updated task progress indicators to improve visibility of student progress:

  • Green → completed tasks
  • Red → failed tasks
  • Grey → remaining tasks

This keeps the original behaviour while improving readability.

Fixes # (ticket number)


Type of Change

  • Refactor
  • UI improvement
  • Breaking change
  • Documentation update

Testing

Tested locally on 10.0.x

Verified:

  • Search functionality
  • Filtering
  • Sorting
  • Pagination
  • CSV export
  • Enrol modal
  • Student navigation
  • Progress bar display

Before screenshots
before2

After screenshots
aftre


Testing Checklist

  • Tested in Microsoft Edge
  • Tested in Chrome
  • Tested in Safari
  • Tested in Firefox

Checklist

  • Self-reviewed
  • Existing functionality verified
  • No unrelated files included
  • Ready for review

Copy link
Copy Markdown

@owens-hub-git owens-hub-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks ok, some things I wanted to ask about:

  • I like the newer style, but I think the blue outline from before was fine and allowed some visual positives where you can see the bounds of the component

  • Are you considering the mobile views? I know most people won't be using it in that way but it shows a weird visual where it's off the screen, shown below:

Image

Copy link
Copy Markdown

@millyamolo millyamolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the PR locally and verified the migrated students-list component works as expected.
The new Angular/TypeScript implementation appears consistent with the existing app structure.
I did not find any regressions in the students list behavior during local testing.
The migration looks complete and ready to merge from my side. Approved

Copy link
Copy Markdown

@millyamolo millyamolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the PR#478 locally and verified the migrated students-list component works as expected.
The new Angular/TypeScript implementation appears consistent with the existing app structure.
I did not find any regressions in the students list behavior during local testing.
The migration looks complete and ready to merge from my side. Approved

@WaelAlahamdi
Copy link
Copy Markdown
Author

Overall this looks ok, some things I wanted to ask about:

  • I like the newer style, but I think the blue outline from before was fine and allowed some visual positives where you can see the bounds of the component
  • Are you considering the mobile views? I know most people won't be using it in that way but it shows a weird visual where it's off the screen, shown below:
Image

Thanks @owens-hub-git, I’ve addressed the mobile layout issue and restored the visual boundary styling. The component has been re-tested on both desktop and mobile views.

Copy link
Copy Markdown

@owens-hub-git owens-hub-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve here as it looks fine visually, I am concerned with the validity of the ts file that goes with it by the complexity difference between the original design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants