feat(dashboard): create skeleton dashboard page#476
feat(dashboard): create skeleton dashboard page#476cillynder wants to merge 3 commits intothoth-tech:Feature/Cross-Unitfrom
Conversation
owens-hub-git
left a comment
There was a problem hiding this comment.
I ran this locally on my machine shown below:
Looks great and fits really well with the existing OnTrack system. One issue I encountered was a visual bug where longer unit codes would cut the later part of a unit shown here:
This may not be an issue if unit codes are within certain length requirements.
I can see you have already got the tasks div below ready for future tasklist component.
Mobile view also looks good, but I need some closure whether we are doing the same scroll to the left and right to see units instead of up and down for units.
UI routing works and I can see the code follows good practice with the rest of the codebase.
Lastly, will the select units button be there as it wasn't in the high fidelity images?
well done
|
Thanks for the review!
|
Awesome, thanks for the response and everything looks good from my end |
also remove some leftover testing code, oops
|
@BrianDangDev need to merge this for cross-unit please |


Description
Creates a skeleton dashboard page that displays columns of units, which will later have task list items under each column. The button in #455 also now properly links to the new page.
Type of change
How Has This Been Tested?
Tested by using docker-compose containers in
development/of doubtfire-deploy to verify layout changes.Testing Checklist:
Checklist: