Migrate student task list#474
Open
millyamolo wants to merge 3 commits intothoth-tech:10.0.xfrom
Open
Conversation
Convert student-task-list.coffee to student-task-list.component.ts Convert student-task-list.tpl.html to student-task-list.component.html Convert student-task-list.scss to student-task-list.component.scss Add student-task-list.component.css for proper styling Update Angular module imports and declarations Update AngularJS module with downgrade directive Update dashboard template to use Angular property bindings Remove old CoffeeScript files Fix filtering and sorting logic Handle taskData gracefully when not provided All original functionality preserved Fixes thoth-tech#472
- Add proper CSS hover styles for task items - Fix taskData initialization in setSelectedTask - Remove debug console logs - Ensure click events work correctly - Add pointer-events management for badges
millyamolo
force-pushed
the
migrate/student-task-list
branch
3 times, most recently
from
21c1bcf to
af0462e
Compare
millyamolo
force-pushed
the
migrate/student-task-list
branch
from
1d6ad6a to
e58eb6b
Compare
WaelAlahamdi
approved these changes
May 3, 2026
WaelAlahamdi
left a comment
WaelAlahamdi
left a comment
There was a problem hiding this comment.
Hi Millicent, thanks for your effort.
The PR has been reviewed and tested locally. It meets the task requirements and no issues were found. Everything looks good.
Approved
Thirus224849242
approved these changes
May 4, 2026
Thirus224849242
left a comment
Thirus224849242
left a comment
There was a problem hiding this comment.
Hi Millicent, The migration appears clean in general, CoffeeScript has been removed, Angular components system has been configured correctly, the downgrade bridge wired up properly. Good Job.
Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the student-task-list component from CoffeeScript/AngularJS to TypeScript/Angular following the frontend migration guide. This modernizes the codebase while maintaining all existing functionality.
Fixes # (issue)
Type of change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
How Has This Been Tested?
The migration has been tested by accessing the student dashboard and verifying all component functionality works as expected. The task list displays, search filtering functions correctly, task selection works, and create portfolio items appear appropriately.
Testing Checklist:
Tested in latest Chrome
Tested in latest Safari
Tested in latest Firefox
Checklist:
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings