feat: add performance bands#468
Conversation
|
I’ve reviewed the PR and everything appears to be in order. Happy to approve. |
davidngash98
left a comment
There was a problem hiding this comment.
Really nice work on this, Faith the feature concept is genuinely useful and the visual design is the standout. The gradient bars, rounded pill tracks, hover elevation, and toggle switch all feel modern. I like the hooking into $watchCollection plus the TaskStatusUpdated event means the bars react live as students complete work rather than going stale. Adding the entry to the project header dropdown was good and discoverable without cluttering the dashboard.
mudith-perera
left a comment
There was a problem hiding this comment.
Good Work Faith!. I’ve reviewed the PR and everything appears to be in order. Happy to approve.
millyamolo
left a comment
There was a problem hiding this comment.
I tasted the PR locally and verified the new performance bands feature works correctly. The UI and behavior looks correct during local testing. I did not see any regressions in the related screens. Ready to approve from my side.
Description
This pull request completely overhauls the "Performance Bands" component on the progress dashboard by migrating it from static mock HTML into a robust, standalone Angular directive.
Previously, the performance bands defaulted to an empty 0% state for students without rigidly graded tasks. This PR implements a dynamic trajectory calculation based on the student's live
$scope.project.activeTasks(). The system now successfully groups task statuses and evaluation criteria into four bands (High Distinction, Above Average, Average, Below Average), guaranteeing a continuous representation of progress throughout the term.Additionally, this change replaces the previous flat CSS layout with a premium, sleek aesthetic featuring physics-like micro-animations, color gradients, and elevation styling.
The change includes:
performance-bands.coffeelogic to dynamically map live task progression instead of static percentage properties.performance-bands.tpl.htmlandperformance-bands.scssinto a premium responsive component with native data bindings.progress-dashboard.tpl.htmland replacing it with the dynamic<performance-bands>directive tag.doubtfire-angularjs.module.tsto actively import the isolated component into the modern Angular bundler pipeline.progress-dashboard.coffeecontroller.Fixes # (issue)
Type of change
How Has This Been Tested?
Test steps:
Testing Checklist:
Checklist: