Skip to content

feat: add performance bands#468

Open
faithque wants to merge 2 commits intothoth-tech:developmentfrom
faithque:feature/performance-bands
Open

feat: add performance bands#468
faithque wants to merge 2 commits intothoth-tech:developmentfrom
faithque:feature/performance-bands

Conversation

@faithque
Copy link
Copy Markdown

@faithque faithque commented Apr 23, 2026

Description

This pull request completely overhauls the "Performance Bands" component on the progress dashboard by migrating it from static mock HTML into a robust, standalone Angular directive.

Previously, the performance bands defaulted to an empty 0% state for students without rigidly graded tasks. This PR implements a dynamic trajectory calculation based on the student's live $scope.project.activeTasks(). The system now successfully groups task statuses and evaluation criteria into four bands (High Distinction, Above Average, Average, Below Average), guaranteeing a continuous representation of progress throughout the term.

Additionally, this change replaces the previous flat CSS layout with a premium, sleek aesthetic featuring physics-like micro-animations, color gradients, and elevation styling.

The change includes:

  • Updating performance-bands.coffee logic to dynamically map live task progression instead of static percentage properties.
  • Refactoring performance-bands.tpl.html and performance-bands.scss into a premium responsive component with native data bindings.
  • Extracting the static HTML card from progress-dashboard.tpl.html and replacing it with the dynamic <performance-bands> directive tag.
  • Updating doubtfire-angularjs.module.ts to actively import the isolated component into the modern Angular bundler pipeline.
  • Dropping obsolete state variables from the progress-dashboard.coffee controller.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Test steps:

  1. Run the project locally.
  2. Log in as a student with active tasks in any unit.
  3. Open the Progress Dashboard view.
  4. Confirm that the "Performance Bands" panel successfully renders dynamic widths based on actual task statuses and does not flatten out at 0%.
  5. Confirm UI responsiveness and toggle visibility functionalities operate smoothly.

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox
  • Tested in latest Microsoft Edge

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from two members of the Frontend Migration team on the Pull Request.
image image image image image image image

@faithque faithque closed this Apr 26, 2026
@faithque faithque reopened this Apr 28, 2026
@mudith-perera
Copy link
Copy Markdown

I’ve reviewed the PR and everything appears to be in order. Happy to approve.

Copy link
Copy Markdown

@davidngash98 davidngash98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work on this, Faith the feature concept is genuinely useful and the visual design is the standout. The gradient bars, rounded pill tracks, hover elevation, and toggle switch all feel modern. I like the hooking into $watchCollection plus the TaskStatusUpdated event means the bars react live as students complete work rather than going stale. Adding the entry to the project header dropdown was good and discoverable without cluttering the dashboard.

Copy link
Copy Markdown

@mudith-perera mudith-perera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work Faith!. I’ve reviewed the PR and everything appears to be in order. Happy to approve.

Copy link
Copy Markdown

@millyamolo millyamolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tasted the PR locally and verified the new performance bands feature works correctly. The UI and behavior looks correct during local testing. I did not see any regressions in the related screens. Ready to approve from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants