Investigate config module dependencies and clean up legacy root-controller usage#464
Open
sheshankarvapally wants to merge 4 commits intothoth-tech:10.0.xfrom
Conversation
WaelAlahamdi
approved these changes
May 6, 2026
WaelAlahamdi
left a comment
There was a problem hiding this comment.
Hi @sheshankarvapally,
Reviewed and tested locally.
The application loads correctly, navigation works as expected, and no console/runtime errors were encountered during testing.
The migration cleanup and legacy CoffeeScript dependency removal align with the task objectives. Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR continues Task 2 by migrating the legacy AngularJS config dependency area away from CoffeeScript as part of the Angular 17 migration effort.
Changes made:
Removed config.coffee
Removed root-controller.coffee because AppCtrl had no functional logic
Removed routing.coffee
Removed runtime.coffee
Removed dependency on the old doubtfire.config module
Updated index.html to remove AppCtrl usage
Kept required config submodules such as:
Investigation Findings:
Testing: