Docs/tasks migration status#460
Open
Sujay-Deakin wants to merge 895 commits intothoth-tech:developmentfrom
Open
Docs/tasks migration status#460Sujay-Deakin wants to merge 895 commits intothoth-tech:developmentfrom
Sujay-Deakin wants to merge 895 commits intothoth-tech:developmentfrom
Conversation
feat: init lti integration
…eadline-warning refactor: require confirmation when setting project plan after the fe…
…on-rebase-onto-origin-8.0.x Migration grade icon rebase onto origin 8.0.x
* chore: migrate/unit-staff-editor - delete old Coffeescript file - delete old template - remove reference to old Coffeescript file - link new component - downgrade new component * chore: migrate/unit-staff-editor - port `unit-staff-editor-component` to Typescript from Coffeescript - port `unit-staff-editor` template to Angular template syntax w/ Angular Material - adjust parent component `Inputs` and attribute bindings * Update README.md * Update README.md --------- Co-authored-by: Boink <40929320+b0ink@users.noreply.github.com>
* fix: revert staff role on error * fix: ensure full search for unit role * chore: fix casing * refactor: use mat table for staff editor * chore: remove unused variables * fix: null check * refactor: use icon button * chore: remove unit staff editor coffeescript file * chore: add back staff editor tooltips
refactor: use students preferred name in greeting chip
…ll-response refactor: check for a valid submission response
…m_and_yarn/lottie-web-5.13.0 build(deps): bump lottie-web from 5.12.2 to 5.13.0
Bumps [angular-mocks](https://github.com/angular/angular.js) from 1.5.11 to 1.8.3. - [Changelog](https://github.com/angular/angular.js/blob/master/CHANGELOG.md) - [Commits](angular/angular.js@v1.5.11...v1.8.3) --- updated-dependencies: - dependency-name: angular-mocks dependency-version: 1.8.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@commitlint/config-conventional](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/config-conventional) from 17.8.1 to 20.5.0. - [Release notes](https://github.com/conventional-changelog/commitlint/releases) - [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/config-conventional/CHANGELOG.md) - [Commits](https://github.com/conventional-changelog/commitlint/commits/v20.5.0/@commitlint/config-conventional) --- updated-dependencies: - dependency-name: "@commitlint/config-conventional" dependency-version: 20.5.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@types/jasmine](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jasmine) from 3.9.1 to 6.0.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jasmine) --- updated-dependencies: - dependency-name: "@types/jasmine" dependency-version: 6.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@ctrl/ngx-emoji-mart](https://github.com/scttcper/ngx-emoji-mart) from 9.2.0 to 9.3.0. - [Release notes](https://github.com/scttcper/ngx-emoji-mart/releases) - [Commits](scttcper/ngx-emoji-mart@v9.2.0...v9.3.0) --- updated-dependencies: - dependency-name: "@ctrl/ngx-emoji-mart" dependency-version: 9.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…pm_and_yarn/ctrl/ngx-emoji-mart-9.3.0 build(deps): bump @ctrl/ngx-emoji-mart from 9.2.0 to 9.3.0
…pm_and_yarn/commitlint/config-conventional-20.5.0 build(deps-dev): bump @commitlint/config-conventional from 17.8.1 to 20.5.0
…pm_and_yarn/angular-mocks-1.8.3 build(deps): bump angular-mocks from 1.5.11 to 1.8.3
…pm_and_yarn/types/jasmine-6.0.0 build(deps-dev): bump @types/jasmine from 3.9.1 to 6.0.0
…pm_and_yarn/rollup-4.59.0 build(deps-dev): bump rollup from 4.18.0 to 4.59.0
…btfire-lms#1132) * refactor: confirm recursive fix and resubmit for dependent tasks * refactor: move logic to task model
Bumps [angular-sanitize](https://github.com/angular/angular.js) from 1.5.11 to 1.8.3. - [Changelog](https://github.com/angular/angular.js/blob/master/CHANGELOG.md) - [Commits](angular/angular.js@v1.5.11...v1.8.3) --- updated-dependencies: - dependency-name: angular-sanitize dependency-version: 1.8.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…re-lms#1138) * feat: pause feedback threshold during teaching period breaks * chore: round down days
- this may be due to the breaks re-calculated client-side
Bumps [node-forge](https://github.com/digitalbazaar/forge) from 1.3.3 to 1.4.0. - [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md) - [Commits](digitalbazaar/forge@v1.3.3...v1.4.0) --- updated-dependencies: - dependency-name: node-forge dependency-version: 1.4.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 1.1.11 to 1.1.13. - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@1.1.11...v1.1.13) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 1.1.13 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…pm_and_yarn/brace-expansion-1.1.13 build(deps-dev): bump brace-expansion from 1.1.11 to 1.1.13
…pm_and_yarn/node-forge-1.4.0 build(deps-dev): bump node-forge from 1.3.3 to 1.4.0
…pm_and_yarn/angular-sanitize-1.8.3 build(deps): bump angular-sanitize from 1.5.11 to 1.8.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR documents the current migration status of the tasks module and highlights remaining blockers for completing the Angular migration.
Completed work
f-unit-task-listfully replaces the legacyunit-task-listviewerwrapper by removing unnecessary AngularJS glue and passing data directly to the Angular componentFindings
inbox,definition,overflow, andmoderationstates still depend on AngularJS-managedtaskDataThese states rely on:
taskData.sourcetaskData.taskDefModetasks.coffeeremains the central controller managing:taskKey)Blocker
Full migration of
tasks.coffeeand remaining task states is currently blocked because Angular components still depend on the AngularJStaskDatastructure.Suggested next steps
$scope.taskDatataskData