feat: migrate vendor-dependencies from CoffeeScript to TypeScript#458
Open
sakethsram8888 wants to merge 2 commits intothoth-tech:10.0.xfrom
Open
feat: migrate vendor-dependencies from CoffeeScript to TypeScript#458sakethsram8888 wants to merge 2 commits intothoth-tech:10.0.xfrom
sakethsram8888 wants to merge 2 commits intothoth-tech:10.0.xfrom
Conversation
millyamolo
reviewed
Apr 17, 2026
millyamolo
left a comment
There was a problem hiding this comment.
This is a solid step toward improving maintainability and supporting the ongoing migration effort. The structure looks clean and uses proper import/export syntax, and the dependencies are clearly defined and easy to follow. From basic testing, the application runs as expected (login works, no console errors, UI loads correctly), so the change appears non-breaking. One minor note is that it still uses angular.module(...), which is expected given the current hybrid AngularJS setup, and it may be worth confirming that any previous CoffeeScript implementation has been fully removed and that no dependencies were missed. Overall, this looks good to me and I’m happy to approve.
millyamolo
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates the vendor-dependencies module from CoffeeScript (AngularJS) to TypeScript (Angular 17).
The file
vendor-dependencies.coffeehas been rewritten asvendor-dependencies.ts, converting the AngularJS module definition to TypeScript while preserving all existing third-party dependencies.The import in
doubtfire-angularjs.module.tshas been updated to reference the new TypeScript file directly instead of the compiled JavaScript build output.Fixes # (issue)
Type of change
How Has This Been Tested?
The application was tested locally at localhost:4200. The app loads correctly and login functionality works as expected with the new TypeScript file in place of the old CoffeeScript file.
Testing Checklist:
Checklist:
old .coffee file

new .ts file

localhost working
