Skip to content

feat: migrate vendor-dependencies from CoffeeScript to TypeScript#458

Open
sakethsram8888 wants to merge 2 commits intothoth-tech:10.0.xfrom
sakethsram8888:migrate/vendor-dependencies
Open

feat: migrate vendor-dependencies from CoffeeScript to TypeScript#458
sakethsram8888 wants to merge 2 commits intothoth-tech:10.0.xfrom
sakethsram8888:migrate/vendor-dependencies

Conversation

@sakethsram8888
Copy link
Copy Markdown

@sakethsram8888 sakethsram8888 commented Apr 17, 2026

Description

Migrates the vendor-dependencies module from CoffeeScript (AngularJS) to TypeScript (Angular 17).

The file vendor-dependencies.coffee has been rewritten as vendor-dependencies.ts, converting the AngularJS module definition to TypeScript while preserving all existing third-party dependencies.

The import in doubtfire-angularjs.module.ts has been updated to reference the new TypeScript file directly instead of the compiled JavaScript build output.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

The application was tested locally at localhost:4200. The app loads correctly and login functionality works as expected with the new TypeScript file in place of the old CoffeeScript file.

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from team on the Pull Request

old .coffee file
image

new .ts file
image

localhost working
image

Copy link
Copy Markdown

@millyamolo millyamolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a solid step toward improving maintainability and supporting the ongoing migration effort. The structure looks clean and uses proper import/export syntax, and the dependencies are clearly defined and easy to follow. From basic testing, the application runs as expected (login works, no console errors, UI loads correctly), so the change appears non-breaking. One minor note is that it still uses angular.module(...), which is expected given the current hybrid AngularJS setup, and it may be worth confirming that any previous CoffeeScript implementation has been fully removed and that no dependencies were missed. Overall, this looks good to me and I’m happy to approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants