Investigate migration of unit-task-list to f-unit-task-list#456
Closed
Sujay-Deakin wants to merge 18 commits intothoth-tech:10.0.xfrom
Closed
Investigate migration of unit-task-list to f-unit-task-list#456Sujay-Deakin wants to merge 18 commits intothoth-tech:10.0.xfrom
Sujay-Deakin wants to merge 18 commits intothoth-tech:10.0.xfrom
Conversation
…btfire-lms#1132) * refactor: confirm recursive fix and resubmit for dependent tasks * refactor: move logic to task model
Bumps [angular-sanitize](https://github.com/angular/angular.js) from 1.5.11 to 1.8.3. - [Changelog](https://github.com/angular/angular.js/blob/master/CHANGELOG.md) - [Commits](angular/angular.js@v1.5.11...v1.8.3) --- updated-dependencies: - dependency-name: angular-sanitize dependency-version: 1.8.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…re-lms#1138) * feat: pause feedback threshold during teaching period breaks * chore: round down days
- this may be due to the breaks re-calculated client-side
Bumps [node-forge](https://github.com/digitalbazaar/forge) from 1.3.3 to 1.4.0. - [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md) - [Commits](digitalbazaar/forge@v1.3.3...v1.4.0) --- updated-dependencies: - dependency-name: node-forge dependency-version: 1.4.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 1.1.11 to 1.1.13. - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@1.1.11...v1.1.13) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 1.1.13 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…pm_and_yarn/brace-expansion-1.1.13 build(deps-dev): bump brace-expansion from 1.1.11 to 1.1.13
…pm_and_yarn/node-forge-1.4.0 build(deps-dev): bump node-forge from 1.3.3 to 1.4.0
…pm_and_yarn/angular-sanitize-1.8.3 build(deps): bump angular-sanitize from 1.5.11 to 1.8.3
Author
|
Hi, I've updated the PR to include removal of the dead code files (unit-task-list.coffee, unit-task-list.scss, unit-task-list.tpl.html) as confirmed by the investigation. The unrelated files in the diff are from the base branch, not from this PR's changes. |
Author
|
Hi, I've created a clean PR with only the relevant files here: #483 . Please review that one instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR investigates the migration status of
unit-task-listand verifies whetherf-unit-task-listhas fully replaced it, leaving the first as dead code.What was checked
unit-task-listf-unit-task-listFindings
Conclusion
f-unit-task-list has completely replaced unit-task-list. The old AngularJS implementation appears to be unused and can be safely removed.
Scope note
This PR does not delete legacy files due to migration constraints. It provides verification evidence to support future cleanup.
Suggested next step
unit-task-listfiles in a follow-up PRviewer.coffeeas the next step in the tasks module migration