Migrate/root controller#452
Conversation
WaelAlahamdi
left a comment
There was a problem hiding this comment.
Hi @Thirus224849242 ,
Reviewed locally and tested successfully. The migration keeps the original AppCtrl behaviour, replaces the old CoffeeScript/AngularJS root controller with the new TypeScript/Angular component, and maintains hybrid app compatibility through the downgrade bridge. No issues from my side. Approved.
millyamolo
left a comment
There was a problem hiding this comment.
Tested locally and the application runs without issues:
Verified that the new Tasks.Component integrates correctly within the hybrid Angular/AngularJS setup. The downgradeComponent configuration appears correct, and no dependency or injection errors were observed after removing the doubtfire.tasks module reference.
Confirmed that existing task-related functionality (including project-tasks-list.coffee and modals.coffee) continues to work as expected, indicating that child AngularJS modules are still loading independently.
The migration aligns with the intended approach of incrementally replacing AngularJS modules without introducing additional logic.
|
@BrianDangDev we have two approvers @Thirus224849242 please open an upstream pull request (against doubtfire-web) |
Description
This PR migrates the
root-controllerfrom CoffeeScript and AngularJS to TypeScript and Angular as part of the ongoing Doubtfire migration effort.The original
AppCtrlcontroller was empty with only aGlobalStateServiceinjection and no implementation. The newRootControllerComponentmaintains this behaviour while following the Angular component pattern.Changes made:
root-controller.component.tsas the Angular replacement forroot-controller.coffeeRootControllerComponentindoubtfire-angular.module.tsdeclarationsRootControllerComponentindoubtfire-angularjs.module.tsusingdowngradeComponentto maintain hybrid app compatibilityAppCtrlcontroller indoubtfire-angularjs.module.tsto maintain compatibility withng-controller="AppCtrl"inindex.htmldoubtfire.config.root-controllerfromconfig.coffeeroot-controller.coffeeFixes # (issue)
Type of change
How Has This Been Tested?
The app was loaded and tested locally after each change to ensure nothing broke. The
ng-controller="AppCtrl"inindex.htmlcontinues to work correctly via thedowngradeComponentbridge.Testing Checklist:
Checklist: