Investigate dependencies - visualisations.coffee

[WaelAlahamdi]

Description

This pull request moves the shared visualisation logic from the AngularJS CoffeeScript factory into a new TypeScript service.

The change introduces a new visualisation.service.ts file to hold the shared chart creation defaults, config setup, analytics tracking, and refresh logic. The service is exposed to the hybrid Angular/AngularJS application through downgradeInjectable, and visualisations.coffee has been updated to act as a compatibility wrapper so existing CoffeeScript visualisation consumers can continue to work without further changes.

This change supports the ongoing migration of the project toward Angular 17 and TypeScript while preserving the current behaviour of the visualisation components.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

The change was tested manually in the local development environment.

Manual testing performed

1. Started the application locally
2. Opened the student dashboard
3. Opened the staff dashboard
4. Verified that the Progress Burndown chart still renders correctly
5. Verified that the Task Statuses chart still renders correctly
6. Confirmed that the visualisation behaviour remained unchanged after the refactor

Additional checks

• Ran npx tsc -p tsconfig.json --noEmit successfully

Testing Checklist:

• Tested in latest Chrome
• Tested in latest Safari
• Tested in latest Firefox

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have requested a review from two members of the Frontend Migration team on the Pull Request

[SteveDala]

I have tested the OnTrack development environment locally with 10.0.x on doubtfire-deploy and doubtfire-api, and @WaelAlahamdi's changed doubtfire-web branch. Nothing appears to have been impacted by this change. At the same time, I don't fully understand the impact of this service on the product. In short, LGTM, but someone who understands Angular17 services might be better to understand this than I am.

[millyamolo]

I tested this PR locally on the migration branch and verified the visualisation refactor behavior in-app. On the dashboard, both Progress Burndown and Task Statuses charts rendered correctly, and I did not observe regressions in chart display/interaction. The Angular service extraction plus CoffeeScript compatibility wrapper appears to preserve existing behavior while supporting the Angular migration path. I am glad to approve it.

[Thirus224849242]

Locally tested on the quality/migrate-visualisation-service branch. Entering the Task Statuses chart as a student and no console errors occurred. Looked at the diff - the new TypeScript service is well-organized with @Injectable, the CoffeeScript file is a simple wrapper with no repeated logic, and the downgradeInjectable wiring of doubtfire-angularjs.module.ts appears to be accurate. Change is localized and there are no unrelated files changed. Approving.

[SteveDala]

@BrianDangDev we have two approvers.

@WaelAlahamdi please open an upstream pull request (against doubtfire-web)