Development#36
Open
faithque wants to merge 3 commits intothoth-tech:developmentfrom
Open
Conversation
## Description This pull request overhauls the "Performance Bands" component on the progress dashboard by replacing the legacy static mock data with a dynamic, robust backend integration. Support for task trajectory evaluation has been added, classifying all active tasks into respective bands based on their live statuses and grading configurations. Additionally, this change replaces the previous flat CSS layout with a premium, sleek aesthetic featuring micro-animations, gradient fills, and elevation physics, aligning seamlessly with the modernized design standards of the application. The change includes: - Updating `performance-bands.coffee` to map actual project tasks and evaluate their statuses/grades into dynamic metrics for performance bands. - Refactoring `performance-bands.tpl.html` and `performance-bands.scss` to deliver a premium user interface with dynamic data bindings and animated progress tracks. - Replacing the static, hard-coded HTML block in `progress-dashboard.tpl.html` with the generic `<performance-bands project="project">` directive tag. - Removing obsolete dummy state variables from the `progress-dashboard.coffee` controller. - Registering the isolated module cleanly in `doubtfire.projects.states.dashboard.directives.performance-bands` and correctly injecting the dependency inside `directives.coffee`. - Properly loading the `.js` compiled file alongside other dashboard directives within `doubtfire-angularjs.module.ts`. Fixes # (issue) ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? **Test steps:** 1. Run the project locally. 2. Log in as a student with active tasks in a unit. 3. Open the Progress Dashboard view. 4. Confirm that the "Performance Bands" panel successfully renders dynamic widths based on the combination of task statuses and grades without yielding 0% flat lines. 5. Confirm that the component's UI toggles correctly and exhibits the smooth hover interactions and loading animations. **Testing Checklist:** - [x] Tested in latest Chrome - [x] Tested in latest Safari - [x] Tested in latest Firefox - [x] Tested in latest Microsoft Edge ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have requested a review from two members of the Frontend Migration team on the Pull Request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request overhauls the "Performance Bands" component on the progress dashboard by replacing the legacy static mock data with a dynamic, robust backend integration. Support for task trajectory evaluation has been added, classifying all active tasks into respective bands based on their live statuses and grading configurations. This guarantees continuous live data flow without sitting at an empty 0% state.
Additionally, this change replaces the previous flat CSS layout with a premium, sleek aesthetic featuring micro-animations, gradient fills, and elevation physics, aligning seamlessly with the modernized design standards of the application.
The change includes:
performance-bands.coffeeto map actual project tasks and evaluate their statuses/grades into dynamic metrics for performance bands.performance-bands.tpl.htmlandperformance-bands.scssto deliver a premium user interface with dynamic data bindings and animated progress tracks.progress-dashboard.tpl.htmlwith the generic<performance-bands project="project">directive tag.progress-dashboard.coffeecontroller.doubtfire.projects.states.dashboard.directives.performance-bandsand correctly injecting the dependency insidedirectives.coffee..jscompiled file alongside other dashboard directives withindoubtfire-angularjs.module.ts.Fixes # (issue)
Type of change
How Has This Been Tested?
Test steps:
Testing Checklist:
Checklist: