Change TWeights in MultiLabelSTAPLE to double - #1
Open
thomas-albrecht wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WeightsType
TWeightsof theitk::MultiLabelSTAPLEImageFilteris set to the defaultfloat.There is one big problem with this.
In itkMultiLabelSTAPLEImageFilter.hxx
the frequency of the labels is computed like this:
where this->m_PriorProbabilities is of course an
Array<WeightsType>.Ultimately, the code is doing this:
At some point, precisely at$frequency = 2^{24} = 16,777,216$ , the float representation of frequency and frequency + 1 is the same and the counter stops increasing. This number easily reached in even a modest 3D images, and the whole
m_PriorProbabilitieswill be completely wrong.Short of changing the ITK code, a simple fix is to use double as the weights type, which raises this problematic threshold to$2^{53} = 9,007,199,254,740,992$ (over 9 quadrillion).