Skip to content

deps: bump cryptoki crate - #3972

Merged
Bravo555 merged 1 commit into
thin-edge:mainfrom
Bravo555:deps/cryptoki-bump
Feb 10, 2026
Merged

Bravo555 merged 1 commit into
thin-edge:mainfrom
Bravo555:deps/cryptoki-bump

Conversation

@Bravo555

@Bravo555 Bravo555 commented Feb 9, 2026

Copy link
Copy Markdown
Member

Proposed changes

cryptoki 0.11 fixes UB when using CKA_ALLOWED_MECHANISMS with softhsm and also removes unmaintained paste crate in 0.12.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

cryptoki 0.11 fixes UB when using CKA_ALLOWED_MECHANISMS with softhsm
and also removes unmaintained paste crate in 0.12.

Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
@Bravo555 Bravo555 added the dependencies Pull requests that update a dependency file label Feb 9, 2026
@Bravo555
Bravo555 temporarily deployed to Test Pull Request February 9, 2026 11:02 — with GitHub Actions Inactive
@codecov

codecov Bot commented Feb 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ates/extensions/tedge-p11-server/src/pkcs11/mod.rs 0.00% 3 Missing ⚠️
crates/extensions/tedge-p11-server/src/service.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
826 0 3 826 100 2h32m20.485941999s

@didier-wenzek didier-wenzek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Comment thread Cargo.toml
# TODO: remove once fix is upstreamed to libloading
[patch.crates-io]
libloading = { git = "https://github.com/Bravo555/rust_libloading.git", branch = "0.8.8" }
libloading = { git = "https://github.com/Bravo555/rust_libloading.git", branch = "0.8.9" }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. This is to remove dl linker flag under musl: nagisa/rust_libloading@master...Bravo555:rust_libloading:0.8.9

What's the plan to get rid of this patch?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once I manage to reproduce the error message that the change is fixing, so I can include it in the PR, I will create a PR to the libloading repository.

I was neglecting to create the PR because I don't really have a good idea of how our build process for musl works such that this error appears, so I can't reproduce the error without actually using our CI pipelline. For this reason, I'm not able to produce a minimal example of this problem showing that this change "fixes" it, or even really describe the problem in detail at all. All i know is that it works for us, but I'm not completely sure that this change is "correct" for the upstream repository, so I was worrying that I won't be able to provide enough context for the maintainer describing why the change is correct.

Nevertheless, I've been putting it off for too long so I will create PR including a best effort description and the error message. If maintainer asks for more details about building for musl, I'll ask @reubenmiller for help.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a bit more research it turns out that perhaps patching libloading was not necessary and we should make the changes in our build process instead: nagisa/rust_libloading#195 (comment)

@Bravo555
Bravo555 added this pull request to the merge queue Feb 10, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 10, 2026
@Bravo555
Bravo555 added this pull request to the merge queue Feb 10, 2026
Merged via the queue into thin-edge:main with commit 17e78b6 Feb 10, 2026
34 checks passed

This branch was previously deployed

2 inactive deployments
Test Auto — 77273218 Deployed Feb 9, 2026 by Bravo555 via Test x86_64 #7117
Test Pull Request — 77273218 Deployed Feb 9, 2026 by Bravo555 via Approve #7117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants