Add Storybook coverage for missing React UI components#565
Add Storybook coverage for missing React UI components#565MD-Mushfiqur123 wants to merge 7 commits into
Conversation
- Root package.json: change test from placeholder error to pnpm -r test - packages/react-ui: change test to vitest run, add vitest dep, add vitest config - Add smoke/unit tests for genui-lib helper functions Closes thesysdev#555
The ChartsV2 directory contains only this document — no implementation was ever built. Add a clear notice at the top and update verbiage throughout so contributors can tell this is a proposal, not the current chart architecture. Closes thesysdev#556
…ToggleItem, ToolCall, ToolResult
ankit-thesys
left a comment
ankit-thesys
left a comment
There was a problem hiding this comment.
Thanks for putting this together, @MD-Mushfiqur123 — the Storybook stories themselves look great and cover everything in #552. 🙌
One request before we can merge: could you keep this PR scoped to just the issue it addresses (#552)? Right now it also bundles in some unrelated work — the Vue chat README, the test-script/vitest changes, and the ChartsV2 ARCHITECTURE.md update. A couple of those have since landed on main separately, which is what's causing the current merge conflict.
Would you mind:
Rebasing onto the latest main and dropping the commits that are already merged, and
Limiting this PR to the packages/react-ui Storybook stories (the 671214a commit)?
The test infrastructure and ChartsV2 doc changes are valuable — they'd just be easier to review and land as their own focused PRs. Keeping one PR per concern helps us review quickly and keeps the history clean.
Thanks again for contributing! 🚀
2 participants
Closes #552