Topology2 : add DTS topology to support PTL#10715
Topology2 : add DTS topology to support PTL#10715joechengxperi wants to merge 1 commit intothesofproject:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a DTS-based topology2 variant for Panther Lake (PTL) SoundWire designs, integrating DTS processing into the SDW speaker and jack playback pipelines and registering a new production topology build target.
Changes:
- Register a new PTL “-dts” cavs-sdw topology target in the ace3 production target list.
- Add DTS-specific SDW amp/jack platform configs and wire them into
cavs-sdw.confviaSDW_*_PIPELINE_SRC=dts. - Introduce a new reusable BE pipeline class
mixout-gain-eqiir-dts-alh-dai-copier-playbackand update related pipeline documentation text.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/topology/topology2/production/tplg-targets-ace3.cmake | Adds a new PTL DTS topology target tuple. |
| tools/topology/topology2/platform/intel/sdw-jack-dts.conf | New DTS jack pipeline definition, including DTS widget + routing. |
| tools/topology/topology2/platform/intel/sdw-amp-dts.conf | New DTS speaker pipeline definition, including DTS widget + routing. |
| tools/topology/topology2/include/pipelines/cavs/mixout-gain-eqiir-dts-dai-copier-playback.conf | Fixes top-of-file pipeline description/comments. |
| tools/topology/topology2/include/pipelines/cavs/mixout-gain-eqiir-dts-alh-dai-copier-playback.conf | Adds a new BE pipeline class for ALH + EQIIR + DTS. |
| tools/topology/topology2/cavs-sdw.conf | Wires dts pipeline source keys to the new platform configs and includes the new pipeline class. |
| Object.Base.route [ | ||
| { | ||
| source "gain.1.1" | ||
| sink "eqiir.1.1" | ||
| } | ||
| { | ||
| source "eqiir.1.1" | ||
| sink "dts.1.1" | ||
| } | ||
| { |
There was a problem hiding this comment.
The routes gain.1.1 -> eqiir.1.1 and eqiir.1.1 -> dts.1.1 are already defined inside the mixout-gain-eqiir-dts-alh-dai-copier-playback pipeline class (via its internal !route list). Duplicating those connections here is redundant and can make the topology harder to reason about (and may risk duplicate route objects depending on how the conf is expanded). Consider removing these two routes and keeping only the external hop(s) from the last processing widget (dts.1.1) to the next widget (module-copier/alh-copier).
There was a problem hiding this comment.
@bardliao I think this one is the same as you mentioned in PR#10678. I've updated it and used the tplgtool2 to verify it again. Thanks.
johnylin76
left a comment
johnylin76
left a comment
There was a problem hiding this comment.
No more comment but the previous one to ask about the common topology build.
|
@joechengxperi could you respond/resolve any copilot comments as this is now needed before merge. Thanks ! |
Sure, I'm working on it. Thanks for remind it. |
Signed-off-by: Joe Cheng <joe.cheng@xperi.com>
joechengxperi
force-pushed
the
main-dts-ptl-tplg-merge
branch
from
3df094c to
7e261bc
Compare
| IncludeByKey.SDW_SPK_ENHANCED_PLAYBACK { | ||
| "true" { | ||
| Object.Widget.module-copier."22" { | ||
| index 21 | ||
| num_input_pins 1 |
There was a problem hiding this comment.
sdw-amp-echo-ref.conf routes from module-copier.21.22 when SDW_SPK_ECHO_REF is enabled, but this DTS speaker topology only defines Object.Widget.module-copier."22" when SDW_SPK_ENHANCED_PLAYBACK is true. If someone builds a DTS speaker topology with SDW_SPK_ENHANCED_PLAYBACK=false (several existing targets do this for high-rate configs) and enables SDW_SPK_ECHO_REF, topology compilation will reference a missing widget. Consider defining module-copier."22" unconditionally (matching sdw-amp-generic.conf / sdw-amp-dax.conf), or at least also gating it on SDW_SPK_ECHO_REF in addition to SDW_SPK_ENHANCED_PLAYBACK.
This change was originally included in PR #10678 and has been split into a standalone PR to simplify maintenance. This separation was requested by @macchian .