fix: honour declared packing and accept both repeated encodings - #11
Merged
Merged
Conversation
The reflection encoder dropped the `packed` flag of a repeated field, so a field declared `packed: false` was still written packed. It is now passed through to the wire. The decoder chose between the packed and the unpacked form by the field's declaration. The protobuf spec requires parsers to accept both encodings of a packable repeated field whatever it is declared as, so the form is now taken from the wire type of the record: a length-delimited record of a packable element type is the packed form, anything else is one element. Strings, bytes and messages are unaffected. OpenEnumTest no longer needs hand-written bytes for the unpacked case. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reflection encoder dropped the
packedflag of a repeated field, so a field declaredpacked: falsewas still written packed. It is now passed through to the wire.The decoder chose between the packed and the unpacked form by the field's declaration. The protobuf spec requires parsers to accept both encodings of a packable repeated field whatever it is declared as, so the form is now taken from the wire type of the record: a length-delimited record of a packable element type is the packed form, anything else is one element. Strings, bytes and messages are unaffected.
OpenEnumTest no longer needs hand-written bytes for the unpacked case.