fix: decode unknown enum values instead of failing - #10
Merged
Merged
Conversation
Proto3 enums are open, but PHP enums are closed: an enum number without a matching case made BackedEnum::from() throw, and the whole message failed to decode. Such numbers are now handled the way protobuf handles closed enums: a singular field (or a oneof variant) is left unset, a repeated field keeps only the known values in order, and every unknown number is kept among the message's unknown fields as a varint with the field's number. A map entry with an unknown enum value is dropped, as the map decoder already drops incomplete entries. Enum numbers are also read as int32 now: negative values, which arrive sign-extended to 64 bits, used to be cast to int directly and broke. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proto3 enums are open, but PHP enums are closed: an enum number without a matching case made BackedEnum::from() throw, and the whole message failed to decode. Such numbers are now handled the way protobuf handles closed enums: a singular field (or a oneof variant) is left unset, a repeated field keeps only the known values in order, and every unknown number is kept among the message's unknown fields as a varint with the field's number. A map entry with an unknown enum value is dropped, as the map decoder already drops incomplete entries.
Enum numbers are also read as int32 now: negative values, which arrive sign-extended to 64 bits, used to be cast to int directly and broke.