Skip to content

[Optimization] Instructor list query #3024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anindra123 wants to merge 1 commit into
base: query_optimization
Choose a base branch
from
Open

[Optimization] Instructor list query #3024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions classes/Instructors_List.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@
tutor_utils()->checking_nonce();

// Check if user is privileged.
if ( ! current_user_can( 'administrator' ) ) {

Check failure on line 153 in classes/Instructors_List.php

View workflow job for this annotation

GitHub Actions / WPCS 

Capabilities should be used instead of roles. Found "administrator" in function call to current_user_can()
wp_send_json_error( tutor_utils()->error_message() );
}

Expand Down Expand Up @@ -399,16 +399,8 @@

$query = "SELECT
DISTINCT user.*,
ins_status.meta_value AS status,
(
SELECT
COUNT(*)
FROM {$wpdb->posts}
WHERE post_author = user.ID
AND post_type = 'courses'
) total_courses
ins_status.meta_value AS status
FROM {$wpdb->users} AS user

INNER JOIN {$wpdb->usermeta} AS ins_status
ON ( user.ID = ins_status.user_id )
AND ins_status.meta_key = '_tutor_instructor_status'
Expand Down
Loading