Repository navigation
fix: resolve './/x' path-tables under the index root - #1603
Merged
Merged
Conversation
…lash-1104 # Conflicts: # packages/rust/tests/path_table_cli_e2e.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1579
A path-table written
.//xresolved against the filesystem root instead of the index root:'.//a/top.md'returned nothing and'.//etc/hostname'read/etc/hostname. After./was stripped, the rest kept its leading/, soindex_root.join(...)replaced the base. The fix trims separators after the leading./, so.//xresolves like./x.Sibling: #1580 (
..folded lexically in absolute/~tables) is in the same module, but it has a separate cause and is not touched here.Red
Red tests pushed alone (974bd9d). CI failed on exactly those assertions (
left: [],right: ["folder/a.md"]/["docs/a.md"]) on Linux and Windows:By hand
Ran the issue's repro with the release binary:
'.//a/top.md'gives[{"path":"a/top.md"}], and'.//etc/hostname'gives[].'.//a','.///a/*.md'and'.//**'givea/top.md.'.//'gives[](no top-level files).E2E Verification
packages/python/e2e-attestations/<branch>.jsonreceipt written ifpackages/pythonchanged (just e2e-attest-python)packages/ts/e2e-attestations/<branch>.jsonreceipt written ifpackages/tschanged (just e2e-attest-ts)cargo test --features cli --test path_table_cli_e2e --test path_table_query --test path_table_globs --test glob_conformance;testing-conventions e2e attest 'pnpm test:e2e'(packages/ts);testing-conventions e2e attest 'uv run python -m pytest tests/e2e/query_contract_test.py tests/e2e/use_case_join_test.py tests/e2e/use_case_dossier_test.py tests/e2e/glob_speed_one_level_test.py tests/e2e/stat_speed_test.py -x -q'(packages/python)Changelog / Migrations
<root>/<pkg>/changelog.d/for each changed package (or:skip-changelogtrailer on a commit with reason)<root>/<pkg>/migrations.d/for each changed package (every subsection but Summary_None._when nothing breaks)