Repository navigation
fix: run config tables' on-file commands in declaration order - #1539
Merged
Merged
Conversation
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1538
Config tables'
on-filecommands run in table declaration order: table N's command finishes before table N+1's starts; across repeated-c, argv order.docs/reference/config.md.Red commit
d1dfd38a(packages/rust/tests/on_file_order.rs) failed in CI on exactly those four assertions (overlappingstart/endlines, or walk/event order).Speed: single-table configs unchanged (speed-of-light e2e tests pass). Multi-table configs lose the cross-table overlap of commands, which the guarantee forbids: 3 tables x 20k files with an awk command, paired runs main vs branch, median ~0.074s -> ~0.092s.
E2E Verification
cargo test --workspace --features cli)packages/python/e2e-attestations/<branch>.jsonreceipt written ifpackages/pythonchanged (just e2e-attest-python)packages/ts/e2e-attestations/<branch>.jsonreceipt written ifpackages/tschanged (just e2e-attest-ts)uv run python -m pytest tests/e2e/{on_file_query,declared_table_name,fanout,query_contract,sigint_interrupt,use_case_notebook,use_case_transcripts,plugin_discovery,frontmatter_parse_speed,jsonl_parse_speed,watch_speed,server_speed}_test.py;pnpm test:e2eChangelog / Migrations
<root>/<pkg>/changelog.d/for each changed package (or:skip-changelogtrailer on a commit with reason)<root>/<pkg>/migrations.d/for each changed package (every subsection but Summary_None._when nothing breaks)