Repository navigation
Speed: ./a/b/**/*.md closer to fd - #1531
Open
thekevinbot wants to merge 5 commits into
Open
thekevinbot wants to merge 5 commits into
thekevinbot wants to merge 5 commits into
Conversation
2 tasks done
thekevinscott
enabled auto-merge
November 3, 2026 01:48
…cores past sixteen Workers spawn as a tree, so the walking thread starts one rather than all of them.
thekevinbot
force-pushed
the
bot/1475-prefix-speed-1016
branch
from
November 3, 2026 13:47
9c539e8 to
6e7d75d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1475
SELECT path FROM './a/b/**/*.md'runs faster. It is not yet held to fd, so this does not close the issue.dirsql query(and baredirsql "<sql>",init,context) builds a current-thread tokio runtime. Onlyserverand the bare REPL keep the multi-thread runtime. Before, a one-shot query started and stopped one tokio worker per core.Rebased onto main, whose walk no longer tracks busy workers; the earlier half-the-cores worker count is dropped.
Measured with hyperfine (30 runs, 800k-file tree, 32 logical cores), main vs this PR:
maincount(*)over./a/b/**/*.mdcount(*)over./**/*.mdThe
./a/b/**/*.mde2e case flakes at its fastest-native bar on main too (main 2/3, this PR 3/3 locally); tracked in #1570.Perf-only change, no red test. New unit tests cover
servesand the worker numbering.Changelog / Migrations
packages/rust/changelog.d/for each changed packagepackages/rust/migrations.d/for each changed package (every subsection but Summary_None._)E2E Verification
cargo test --workspace --features cli)packages/python/e2e-attestations/<branch>.jsonreceipt writtenpackages/ts/e2e-attestations/<branch>.jsonreceipt writtenpackages/python, aftermaturin develop --releaseandcargo build --release -p dirsql --features cli:testing-conventions e2e attest 'uv run python -m pytest tests/e2e/glob_speed_*_test.py tests/e2e/stat_speed_test.py tests/e2e/frontmatter_parse_speed_test.py tests/e2e/jsonl_parse_speed_test.py tests/e2e/query_contract_test.py tests/e2e/fanout_test.py tests/e2e/repl_interactive_test.py tests/e2e/server_speed_test.py -q'; inpackages/ts:testing-conventions e2e attest 'pnpm test:e2e';cargo test --workspace --features cli