Repository navigation
perf: build a path row from the scanned allocation and free big row sets off thread - #1501
Merged
Merged
Conversation
…, free big row sets off thread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1474, #1477, #1482, #1461.
A matched file's path is built from the scanned allocation instead of copied,
query_eachreuses its cell buffers, and a large evicted row set is freed off the evicting thread.Red: c883de0 (run 38187965400) failed on the three new unit tests (
a_row_without_a_prefix_keeps_the_scanned_path_allocation,a_large_evicted_row_set_is_freed_off_the_evicting_thread,filling_a_text_cell_with_text_reuses_its_buffer)../**/*.mdrecursive./**/*.mddepth./*one levelNo case crosses the 1.1x tolerance, so no bar flips.
Changelog
packages/rust/changelog.d/2026-10-11-faster-path-rows.mdMigrations
packages/rust/migrations.d/2026-10-11-faster-path-rows.md(none needed)E2E Verification
testing-conventions e2e attestover the glob_speed_*, stat_speed, query_contract python tests (26 passed);testing-conventions e2e attest 'pnpm test:e2e'in packages/ts (18 passed)