Repository navigation
Inject query effects for CLI unit tests - #1365
Closed
thekevinbot wants to merge 9 commits into
Closed
thekevinbot wants to merge 9 commits into
thekevinbot wants to merge 9 commits into
Conversation
skip-changelog: exercise CLI query output without starting the index
skip-changelog: unit-test isolation import cleanup
skip-changelog: receipt withdrawn until full suite passes
thekevinbot
enabled auto-merge
October 6, 2026 11:43
Collaborator
Author
|
Superseded by main's run_query rewrite (injected writer and a streaming JSON path). The run.rs exemption is still on main; it will be redone in a fresh PR from main. |
auto-merge was automatically disabled
October 6, 2026 15:59
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1330
Move one-shot query output and error handling behind injected state, execution, and writer effects. Unit tests exercise both successful rows and query failures, removing the corresponding mutation waiver. Added an end-to-end
run_cliunit test that checks both successful and failed query exit codes, killing the wrapper mutants.E2E Verification
cargo test -p dirsql --lib --features cli cli::run::tests(58 passed).cargo clippy -p dirsql --all-targets --features cli -- -D warnings.Required preflight had one expected failure at Python e2e freshness because the full suite is red on the known main failure; all other gates passed.
Changelog / Migrations
skip-changelogcommit records behavior-preserving unit coverage; no public API or runtime behavior changed.