Skip to content

Inject query effects for CLI unit tests - #1365

Closed
thekevinbot wants to merge 9 commits into
mainfrom
claude/1330-cli-exit
Closed

thekevinbot wants to merge 9 commits into
mainfrom
claude/1330-cli-exit

Conversation

@thekevinbot

@thekevinbot thekevinbot commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Refs #1330

Move one-shot query output and error handling behind injected state, execution, and writer effects. Unit tests exercise both successful rows and query failures, removing the corresponding mutation waiver. Added an end-to-end run_cli unit test that checks both successful and failed query exit codes, killing the wrapper mutants.

E2E Verification

  • Python e2e receipt pending: main's Python e2e is red on glob_speed_depth_bound_test until Test one-level glob listings at speed of light #1317 merges; full-suite receipt will be written then. Latest full unfiltered run: 8 passed, then the known depth-bound glob failed (9.555s minus 0.041s startup vs 1.868s budget).
  • TypeScript SDK e2e: full suite passed (18 tests); receipt written for latest source commit.
  • Rust unit tests: cargo test -p dirsql --lib --features cli cli::run::tests (58 passed).
  • Rust lint: cargo clippy -p dirsql --all-targets --features cli -- -D warnings.

Required preflight had one expected failure at Python e2e freshness because the full suite is red on the known main failure; all other gates passed.

Changelog / Migrations

  • skip-changelog commit records behavior-preserving unit coverage; no public API or runtime behavior changed.
  • Migration fragment not needed for test-only coverage.

@thekevinbot
thekevinbot enabled auto-merge October 6, 2026 11:43
@thekevinbot

Copy link
Copy Markdown
Collaborator Author

Superseded by main's run_query rewrite (injected writer and a streaming JSON path). The run.rs exemption is still on main; it will be redone in a fresh PR from main.

@thekevinbot thekevinbot closed this Oct 6, 2026
auto-merge was automatically disabled October 6, 2026 15:59

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant