Repository navigation
Remove Python hermetic core patch waiver - #1352
Merged
Merged
Conversation
skip-changelog: internal test seam with no public behavior change
skip-changelog: receipt withdrawn until full suite passes
thekevinbot
enabled auto-merge
October 6, 2026 11:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1332
Refs #1330
Route Rust core construction through a private overridable factory method. Hermetic tests now inject the fake core through a
DirSQLsubclass instead of patching the first-party core symbol; remove the matching testing-conventions waiver.E2E Verification
packages/python/e2e-attestations/claude-1330-python-dirsql-patch.json. Impacted files only (every e2e file that builds aDirSQL, since the change reroutes core construction):capture_collision_test.py,fanout_test.py,cli_version_test.py,extension_package_test.py,on_file_query_test.py,sigint_interrupt_test.py,plugin_extension_discovery_test.py,plugin_discovery_test.py,query_contract_test.py-- 26 passed. Command:testing-conventions e2e attest 'uv run python -m pytest tests/e2e/<impacted files> -x -q'