Skip to content

Remove equivalent vtab mutation waiver #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thekevinbot merged 10 commits into from
Oct 6, 2026
Merged

Remove equivalent vtab mutation waiver #1350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
09b93a0
Remove equivalent vtab mutation waiver
thekevinbot Oct 6, 2026
e8ed6c1
e2e attestation for claude/1330-vtab-prefetch-flag
thekevinbot Oct 6, 2026
4069a32
Merge remote-tracking branch 'origin/main' into claude/1330-vtab-pref…
thekevinbot Oct 6, 2026
9de2f79
e2e attestation for claude/1330-vtab-prefetch-flag
thekevinbot Oct 6, 2026
971339e
Remove incomplete Python e2e receipt
thekevinbot Oct 6, 2026
eef718e
Merge remote-tracking branch 'origin/main' into claude/1330-vtab-pref…
thekevinbot Oct 6, 2026
e07ff6d
e2e attestation for claude/1330-vtab-prefetch-flag
thekevinbot Oct 6, 2026
bcedde4
Merge origin/main into claude/1330-vtab-prefetch-flag
thekevinbot Oct 6, 2026
960cd76
e2e attestation for claude/1330-vtab-prefetch-flag
thekevinbot Oct 6, 2026
0ef9e16
e2e attestation for claude/1330-vtab-prefetch-flag
thekevinbot Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/python/e2e-attestations/claude-1330-vtab-prefetch-flag.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"command": "uv run python -m pytest tests/e2e/query_contract_test.py tests/e2e/declared_table_name_test.py tests/e2e/fanout_test.py -x -q",
"ran_at": 1791310416,
"exit_code": 0,
"commit": "bcedde49401cf6f9cc01deb2d95af1d1e907f0f7",
"branch": "claude/1330-vtab-prefetch-flag"
}
2 changes: 1 addition & 1 deletion packages/rust/src/vtab_scaffold.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ fn lookup_cost(prefetch: bool) -> f64 {
fn plan_idx_num(lookup: Option<usize>, prefetch: bool) -> c_int {
let lookup = lookup.map_or(SCAN_IDX, lookup_idx_num);
if prefetch {
lookup | PREFETCH_IDX
lookup + PREFETCH_IDX
} else {
lookup
}
Expand Down
7 changes: 7 additions & 0 deletions packages/ts/e2e-attestations/claude-1330-vtab-prefetch-flag.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"command": "pnpm test:e2e",
"ran_at": 1791310512,
"exit_code": 0,
"commit": "960cd7611f05e3e93ba4c485e19713e98beca405",
"branch": "claude/1330-vtab-prefetch-flag"
}
Loading