Repository navigation
Plugin launcher no longer injects --include-default - #1347
Merged
Merged
Conversation
thekevinbot
marked this pull request as ready for review
October 6, 2026 02:20
thekevinscott
enabled auto-merge
October 6, 2026 11:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the
--include-defaultinjection from the Python plugin launcher so a plugin adds its functions and nothing else. Nothing else used the hidden--include-defaultflag ordefault_records_table, so both are removed, along with the now-deaduser_passed_confighelper. Docs fixed indocs/reference/cli.md(Plugins) anddocs/howto/write-a-plugin.md(Boundaries).Fixes #1225
Changelog / Migrations
packages/{python,rust}/changelog.d/packages/{python,rust}/migrations.d/E2E Verification
packages/python/e2e-attestations/claude-1225-plugin-no-default.json. Impacted files only (plugin launch / config path):plugin_discovery_test.py,plugin_extension_discovery_test.py,extension_package_test.py,cli_version_test.py,query_contract_test.py-- 19 passedjust e2e-attest-ts)cargo test --features cli --workspacepasses except watcher tests that fail only under inotify exhaustion from parallel agents (pass alone)packages/ts/e2e-attestations/claude-1225-plugin-no-default.jsonreceipt writtentesting-conventions e2e attest 'uv run python -m pytest tests/e2e/<impacted files> -x -q',just e2e-attest-ts