Repository navigation
Test recursive and prefixed globs against find at speed of light - #1323
Merged
Merged
Conversation
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Speed-of-light e2e test for recursive globs:
'./**/*.md'over a deep, wide tree, and'./a/b/**/*.md', wherea/bholds a quarter of the tree..txtfiles, dotfiles and dot-named directories, which globstar with dotglob off must not return.find, pruning dot-named entries. It beats bash globstar here.Fixes #1306
Status: dirsql misses the bar
Rows match native for both globs. Speed does not.
Test run on main (startup 0.04s):
'./**/*.md''./a/b/**/*.md'Direct timing on a 1.6M-file tree built by the test's own builder (release CLI, warm cache):
./**/*.mdcount(*)over./**/*.md./a/b/**/*.mda/b.Fixes land in PRs stacked on this one.
E2E Verification
N/A: test-only change. The new e2e test is the red. No receipt, because no package source changed.