Repository navigation
Brace groups follow bash: no comma or sequence means literal - #1263
Merged
Merged
Conversation
A brace group with neither a top-level comma nor a .. range is literal text; ranges expand to each value.
4 of 14 tasks
Brace expansion now feeds main's PathGlob: every word adds to the file set and the spelled dot names, and each word's components run as their own path through the symlink state machine.
3 tasks done
…eral # Conflicts: # packages/rust/src/scanner.rs # packages/rust/tests/path_table_globs.rs # testing-conventions.toml
thekevinscott
enabled auto-merge
October 5, 2026 18:32
…eral # Conflicts: # packages/rust/tests/path_table_cli_e2e.rs # packages/rust/tests/path_table_globs.rs # testing-conventions.toml
…eral # Conflicts: # testing-conventions.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1262
Path-table braces now expand as bash expands them before globbing. A group with a top-level comma is an alternation (nesting allowed). A
..range ({1..3},{a..c},{01..10},{1..10..2}) expands to each value. Any other brace is literal text, so'./br/{q}.md'namesbr/{q}.md. Expansion lives in the shared core (brace::expand, called fromscanner::compile_glob), so the CLI and all SDKs behave the same. Config[[table]] globis unchanged.Checked against
bash -O globstar -c 'shopt -u dotglob; ...'on a fixture. These all match:{q}*,{a,b}.md,{1..3}.md,{a..c}.md,x{q}.md,{x,{q}}.md,{x,{q}}*,{*(unbalanced),{}*,}*,{1..3..2}.md. The edge-case unit tests (x{}a,b}y,xx{a..}y,b},{-01..1},{Y..[},x{a{b,c}}y,{-0..10..5},{1..3..-1}) agree withechoin bash. After merging main, braces also match bash across symlinks and dot names:{lnk/f.md,a.md},{lnk,real}/*.md,{lnk/sub,.h}/*,{.env,a.md},{q}/*,**/{f,g}.md.E2E Verification
path_table_cli_e2ebrace cases, run under--features cli)packages/python/e2e-attestations/claude-1262-brace-literal.jsonreceipt written ifpackages/pythonchanged (just e2e-attest-python)packages/ts/e2e-attestations/claude-1262-brace-literal.jsonreceipt written ifpackages/tschanged (just e2e-attest-ts)just e2e-attest-python,just e2e-attest-ts,cargo test --workspace --features clicargo test --workspace --features clipasses. Braces compose with POSIX classes and non-ASCII?as bash does (br/{[[:digit:]],q}.md,br/caf?.md,br/a{1..3..2}.md,br/{q}.mdchecked by hand). Local scoped preflight could not run (npx ENOENT in the pnpm store); CI runs the gates.