Skip to content

ci: ratchet one-function-per-file to max_lines = 15 #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thekevinscott merged 1 commit into from
Sep 5, 2026
Merged

ci: ratchet one-function-per-file to max_lines = 15 #1048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internals/checks/testing-conventions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# its own config drops that phantom root; a change to decide.py's path list still
# demands a receipt through the normal --scope internals/checks/src walk.
[python]
one_function_per_file = { max_lines = 16 }
one_function_per_file = { max_lines = 15 }

[python.coverage]
fail_under = 100
Expand Down
2 changes: 1 addition & 1 deletion packages/python/testing-conventions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
extra_scope = ["packages/rust/src", "packages/python/src"]

[python]
one_function_per_file = { max_lines = 16 }
one_function_per_file = { max_lines = 15 }

# Same floor as the root file, which this lane no longer reads.
[python.coverage]
Expand Down
2 changes: 1 addition & 1 deletion packages/ts/testing-conventions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
extra_scope = ["packages/rust/src", "packages/ts/napi"]

[typescript]
one_function_per_file = { max_lines = 16 }
one_function_per_file = { max_lines = 15 }

# Same floors as the root file, which this lane no longer reads.
[typescript.coverage]
Expand Down
2 changes: 1 addition & 1 deletion plugins/dirsql-plugin-embeddings/testing-conventions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# exemptions, and deliberately no `[e2e] extra_scope` -- this package compiles
# none of packages/rust/src, so a core change never stales its attestation.
[python]
one_function_per_file = { max_lines = 24 }
one_function_per_file = { max_lines = 10 }

[python.coverage]
fail_under = 100
Expand Down
4 changes: 2 additions & 2 deletions testing-conventions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ extra_scope = ["packages/rust/src"]
# --- Python (scanned: packages/python/dirsql) ------------------------------

[python]
one_function_per_file = { max_lines = 16 }
one_function_per_file = { max_lines = 15 }

# Unit-only coverage floor (branch coverage on, matching the prior --cov-branch).
# The default for a config-less python caller (internals/distcheck); the
Expand All @@ -99,7 +99,7 @@ branch = true
# build_command field), with `rust_toolchain: true` on the caller supplying cargo.

[typescript]
one_function_per_file = { max_lines = 16 }
one_function_per_file = { max_lines = 15 }

# Unit-only coverage floor, per vitest metric.
[typescript.coverage]
Expand Down
Loading