Skip to content

test(rust): drop the cold-run wall-clock floor from the persist cache test #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thekevinscott merged 2 commits into from
Sep 4, 2026
Merged

test(rust): drop the cold-run wall-clock floor from the persist cache test #1029

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb147fc
test(rust): drop the cold-run wall-clock floor from the persist cache…
thekevinbot Sep 2, 2026
7334d5b
Merge remote-tracking branch 'origin/main' into claude/1021-cold-floo…
thekevinbot Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions packages/rust/tests/persist_parsed_path_table.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ use std::time::{Duration, Instant, SystemTime};
use tempfile::TempDir;

/// Files in the synthetic corpus for the timing test. The parser spawns one
/// process per file, so this is sized to put the cold run comfortably above
/// the 3s floor the ratio assertion needs to mean anything.
/// process per file, so this is sized to make per-file parsing, not the fixed
/// cost of a run, the bulk of the cold run's work.
const CORPUS: usize = 4_000;

/// The second run must cost no more than this share of the first.
Expand Down Expand Up @@ -153,11 +153,6 @@ fn unchanged_second_run_reuses_the_cache_instead_of_reparsing() {
let (cold_rows, cold) = fx.run(&parser, true);
assert_eq!(fx.parses(), CORPUS, "the cold run parses every file once");
assert_eq!(cold_rows.len(), CORPUS);
assert!(
cold >= Duration::from_secs(3),
"the corpus must be big enough for the ratio assertion to mean \
something; the cold run took {cold:?} — raise CORPUS",
);

let size_before = fx.cache_size();
let digest_before = fx.cache_digest();
Expand Down
Loading