Skip to content

CI paths: TS Test — add internals/distcheck, exclude fragment/attestation dirs #848

Closed

Description

@thekevinbot

Part of #834. Phase 1 (unanchored corrections — no dependency on any other slice).

What

Same two defects as the Python Test slice:

  1. Missing internals/distcheck/**. ts-test.yml:244 runs dirsql-distcheck node, so this workflow consumes that package but a distcheck-only PR does not trigger it. Spec row 9.
  2. Over-triggers on packages/ts/**, which pulls in changelog.d/, migrations.d/ and e2e-attestations/ (spec rows 14 and 15).

Exact change

.github/workflows/ts-test.yml — replace the on: block with:

on:
  push:
    branches: [main]
    paths:
      - 'packages/ts/**'
      - '!packages/ts/changelog.d/**'
      - '!packages/ts/migrations.d/**'
      - '!packages/ts/e2e-attestations/**'
      - 'packages/rust/**'
      - 'internals/distcheck/**'
      - 'Cargo.toml'
      - 'Cargo.lock'
      - '.github/workflows/ts-test.yml'
  pull_request:
    paths:
      - 'packages/ts/**'
      - '!packages/ts/changelog.d/**'
      - '!packages/ts/migrations.d/**'
      - '!packages/ts/e2e-attestations/**'
      - 'packages/rust/**'
      - 'internals/distcheck/**'
      - 'Cargo.toml'
      - 'Cargo.lock'
      - '.github/workflows/ts-test.yml'

Ordering matters — the ! exclusions must directly follow the packages/ts/** they narrow (last match wins).

packages/ts/** already covers napi/, package.json, tsconfig*.json and the pnpm lockfiles, so spec rows 7 and 19 need no extra entries here.

Do not add testing-conventions.toml — TS unit coverage moved into the reusable workflow (ts-test.yml:199).

Expected checks on this PR

Files touched: .github/workflows/ts-test.yml only.

MUST run

  • TS Test

MUST NOT run

  • Python Test, Rust Test, Plugins Test, Python Lint, Python Typecheck, TS Lint, TS Typecheck

May still run (not yet filtered)

  • Conventions (all 8 lanes), Release Precheck, Release Config Check, Changelog Check

Optional probe for the two new behaviours, same recipe as the Python Test slice: a throwaway commit touching internals/distcheck/README.md (expect TS Test present), then one touching only packages/ts/e2e-attestations/ (expect TS Test absent). Drop before merging.

Acceptance

  • The PR's check list matches the three groups above exactly
  • Mergify Merge Protections green
  • Merge, close this issue

Notes

  • No changelog fragment, no e2e attestation. Not anchored in .mergify.yml.

Activity

  1. thekevinbot commented on Aug 20, 2026

    @thekevinbot
    CollaboratorAuthor

    Closing in the #934 sweep. The target workflow was replaced by the consolidated per-SDK workflow (#892/#893, part of the #834 epic shipping as per-domain consolidation). Defect 2 (fragment/attestation over-triggering) is resolved there: changelog.d//migrations.d/ are excluded (attestations now correctly trigger, since the e2e-verify lane lives in the same workflow as the tests). Defect 1 (missing internals/distcheck/**) is still real in the consolidated workflows — re-filed against the current files as #961.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions