You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
CI paths: TS Test — add internals/distcheck, exclude fragment/attestation dirs #848
Part of #834. Phase 1 (unanchored corrections — no dependency on any other slice).
What
Same two defects as the Python Test slice:
Missing internals/distcheck/**.ts-test.yml:244 runs dirsql-distcheck node, so this workflow consumes that package but a distcheck-only PR does not trigger it. Spec row 9.
Over-triggers on packages/ts/**, which pulls in changelog.d/, migrations.d/ and e2e-attestations/ (spec rows 14 and 15).
Exact change
.github/workflows/ts-test.yml — replace the on: block with:
Optional probe for the two new behaviours, same recipe as the Python Test slice: a throwaway commit touching internals/distcheck/README.md (expect TS Test present), then one touching only packages/ts/e2e-attestations/ (expect TS Test absent). Drop before merging.
Acceptance
The PR's check list matches the three groups above exactly
Mergify Merge Protections green
Merge, close this issue
Notes
No changelog fragment, no e2e attestation. Not anchored in .mergify.yml.
Closing in the #934 sweep. The target workflow was replaced by the consolidated per-SDK workflow (#892/#893, part of the #834 epic shipping as per-domain consolidation). Defect 2 (fragment/attestation over-triggering) is resolved there: changelog.d//migrations.d/ are excluded (attestations now correctly trigger, since the e2e-verify lane lives in the same workflow as the tests). Defect 1 (missing internals/distcheck/**) is still real in the consolidated workflows — re-filed against the current files as #961.
Activity
thekevinbot commentedon Aug 20, 2026
Closing in the #934 sweep. The target workflow was replaced by the consolidated per-SDK workflow (#892/#893, part of the #834 epic shipping as per-domain consolidation). Defect 2 (fragment/attestation over-triggering) is resolved there:
changelog.d//migrations.d/are excluded (attestations now correctly trigger, since the e2e-verify lane lives in the same workflow as the tests). Defect 1 (missinginternals/distcheck/**) is still real in the consolidated workflows — re-filed against the current files as #961.