Skip to content

refactor(checks): split platforms_mirror/typescript_table.py and gate.py toward max_lines = 1 #1064

Closed

Description

@thekevinbot

Step under #1020. Lane C, internals/checks/src/checks/platforms_mirror/ — PR 3 of 3.

Measured against origin/main at f575c06 with the ceiling set to 1
(npx -y testing-conventions@0.0.111):

typescript_table.py:31 `_without_comments` runs 4 lines
typescript_table.py:39 `_as_json` runs 2 lines
typescript_table.py:44 `typescript_table` runs 15 lines
gate.py:23             `run` runs 22 lines

Four flagged violations, four moves. typescript_table.py keeps
typescript_table and sheds _requoted, _without_comments (with the _TOKENS
pattern it owns) and _as_json; gate.py keeps run and moves read out.

Stacks on the decide.py slice: that PR rewrites gate.py's failure message,
which names the module holding SHARED by path, so both PRs touch gate.py.

No config change; no changelog fragment (internals/** is out of scope).

Activity

  1. self-assigned this
    on Sep 5, 2026
  2. thekevinbot commented on Sep 5, 2026

    @thekevinbot
    CollaboratorAuthor

    Done on main via #1102, which split typescript_table.py and gate.py (and the rest of platforms_mirror) past this ceiling. internals/checks/src reports zero one-function-per-file violations at max_lines = 1 on 3a1e427, confirmed with a planted-violation positive control. #1089, the PR opened against this issue, was closed as redundant — its four new modules already exist on main with identical bodies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions