Skip to content

persist_parsed_path_table asserts a wall-clock floor and fails on a fast machine #1028

Closed as not planned

Description

@thekevinbot

unchanged_second_run_reuses_the_cache_instead_of_reparsing in packages/rust/tests/persist_parsed_path_table.rs:156 fails on clean main:

the corpus must be big enough for the ratio assertion to mean something;
the cold run took 2.282013488s — raise CORPUS

The test asserts cold >= Duration::from_secs(3) to guarantee the later cold/warm ratio assertion has headroom. That floor is calibrated to the CI runner. On a faster machine the cold run finishes under it and the test fails — not because the cache behavior regressed, but because the machine did the work too quickly.

A wall-clock floor makes the suite's outcome a function of host speed, and it fails in the direction of "your machine is fast", which reads as a real failure to anyone running cargo test --workspace --features cli locally. Better to assert the invariant directly (the warm run parses zero files, which fx.parses() already gives) than to gate it behind a duration.

Found while running the Rust suite for #1002; reproduced on a clean main worktree.

Activity

  1. thekevinbot commented on Sep 2, 2026

    @thekevinbot
    CollaboratorAuthor

    Duplicate of #1021, which reports the same wall-clock floor in the same test. Closing in favor of the earlier issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions