Skip to content

REPL e2e tests still assert JSON output after table rendering landed #1027

Closed

Description

@thekevinbot

Five tests in packages/python/tests/e2e/repl_interactive_test.py fail on clean main (01c3c66):

it_recalls_the_previous_statement_with_the_up_arrow
it_keeps_history_across_sessions
it_writes_history_where_xdg_says
it_abandons_a_line_on_ctrl_c_without_ending_the_session
it_shows_a_continuation_prompt_until_the_terminator

They assert [{"n":41}]; the REPL now draws

n
--
41

1 row

Cause is ordering, not environment. cb75f4e ("line editing, history, and multi-line entry in the REPL") landed 2026-08-20 21:38 UTC with these assertions. 060576f ("render rows as a table when they are read rather than piped") landed 22:33 UTC the same day and changed what a pty-attached REPL prints. The tests were never updated.

E2E is not in CI, so nothing caught it. The practical cost: just e2e-attest-python runs the whole suite and requires exit 0, so no PR touching packages/python or packages/rust/src can refresh its attestation until this is fixed.

Found while shepherding #1002; reproduced on a clean main worktree, so it is not that PR's.

Activity

  1. self-assigned this
    on Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions