Skip to content

Improve Debian 13 support: hammer, IPA auth, bug fixes - #427

Open
jakduch wants to merge 5 commits into
theforeman:debianfrom
jakduch:debian-13-improvements
Open

Improve Debian 13 support: hammer, IPA auth, bug fixes#427
jakduch wants to merge 5 commits into
theforeman:debianfrom
jakduch:debian-13-improvements

Conversation

@jakduch

@jakduch jakduch commented Mar 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Rebased onto the current debian branch. Changes that are already present in the base branch, including Debian repository setup, were dropped during the rebase.

The remaining changes:

  • Make HTTPD IPA external authentication OS-aware, using Debian module packages and a2enmod/a2dismod where appropriate
  • Fix the httpd_conf_path expansion in the external-auth cleanup task
  • Use OS-specific Hammer package names for Debian and Red Hat systems
  • Use the OS-specific Apache account for the Foreman and Pulp systemd sockets
  • Deploy Hammer in the Debian CI job and run its feature tests instead of marking them as expected failures

@jakduch jakduch mentioned this pull request Mar 28, 2026
Draft
@jakduch

jakduch commented Mar 28, 2026

Copy link
Copy Markdown
Contributor Author

This PR builds on @evgeni's Debian 13 work in #235. It targets the debian branch directly so the commits can be cherry-picked or merged into #235.

See my comment on #235 for the full description of changes.

@evgeni
evgeni force-pushed the debian branch 4 times, most recently from 5fe9467 to feb639e Compare June 3, 2026 13:49
@evgeni
evgeni force-pushed the debian branch 7 times, most recently from a757829 to a7faf2e Compare June 25, 2026 07:21
@ehelms
ehelms marked this pull request as draft July 22, 2026 01:45
@ehelms

ehelms commented Jul 22, 2026

Copy link
Copy Markdown
Member

Moving to draft as this will need a rebase and update to match the current state of the code base.

@evgeni
evgeni force-pushed the debian branch 2 times, most recently from 90ad408 to b1948f3 Compare September 9, 2026 11:04
@jakduch
Make httpd IPA external auth OS-aware for Debian
03e47a9 
- Use OS-specific package names for IPA Apache modules
  (mod_* on RedHat, libapache2-mod-* on Debian)
- On RedHat: load modules via conf files in conf.modules.d
- On Debian: enable modules via apache2_module (a2enmod)
- Add httpd_ipa_packages and httpd_ipa_load_modules to
  both RedHat.yaml and Debian.yaml vars
@jakduch
Make hammer role OS-aware with Debian package names
92e0f92 
Add OS-specific vars files for hammer role to use correct package
naming conventions (hammer-cli-plugin-* on RedHat, ruby-hammer-cli-*
on Debian). Load OS vars via include_vars and remove hardcoded
package name pattern from defaults.
@jakduch
Fix IPA auth cleanup for Debian and fix extra space in path
0734d3d 
- Fix spurious space in httpd_conf_path variable expansion
- On RedHat: remove module conf files from conf.modules.d
- On Debian: disable modules via apache2_module (a2dismod)
- Use httpd_ipa_load_modules flag to select correct method
@jakduch
enabled Hammer deployment on Debian in CI
573c2d5 
Ran the Hammer deployment and its feature tests on Debian after adding OS-specific package names.
@jakduch
jakduch force-pushed the debian-13-improvements branch from 1416454 to 573c2d5 Compare September 25, 2026 08:17
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 78dcb573-64d2-427e-9085-a20b512df9e7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jakduch
jakduch marked this pull request as ready for review September 25, 2026 08:17
@jakduch

jakduch commented Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto the current debian branch and updated the remaining changes to match the current code. The Debian commits already present upstream were dropped, including the repository setup that is now handled by setup_repositories. The remaining diff keeps the OS-aware IPA and Hammer setup, enables Hammer in the Debian CI job, and removes the Debian xfails so the Hammer feature tests actually run. Marking this ready for review again.

@jakduch
fixed socket ownership on Debian
0d249fd 
Used the OS-specific Apache account for Foreman and Pulp systemd sockets so Debian does not fail with status 217/USER.
@jakduch

jakduch commented Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

The first rebased CI run exposed one real Debian failure: foreman.socket used the hard-coded apache account and systemd failed with 217/USER. I switched the Foreman and Pulp sockets to the existing OS-specific httpd_user value (www-data on Debian, apache on Red Hat). The other matrix failures all happened before deployment while Vagrant Cloud returned HTTP 502 for box metadata; the new push has started a full pipeline again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Not yet reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakduch @ehelms