Conversation
adamruzicka
reviewed
Sep 15, 2026
snarya07
force-pushed
the
feature/test_case
branch
from
September 15, 2026 18:38
6f2d722 to
1c00bd1
Compare
…ts settings is disabled
snarya07
force-pushed
the
feature/test_case
branch
from
September 15, 2026 18:47
1c00bd1 to
7bd74a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #39630 — REX Job Wizard shows "0 selected hosts" when triggered from Hosts Overview page with
display_fqdn_for_hostssettings is disabledRoot cause
When scheduling a job from host Overview with
display_fqdn_for_hostsdisabled,autofill.jsstored the shortdisplay_namein thenameproperty used bybuildHostQuery. That produced aname ^ (shortname)search against the FQDN stored in the database, so the host preview showed 0 hosts even though the host was fetched by ID.displayNamefor UI labels, and resolves non-numeric host_ids[] withname ^ (hostname)instead ofid = hostname.Fix
buildHostSearchFromIds()for correct API search by ID or hostnamename(canonical FQDN) anddisplayName(UI label) separately in autofill host targetsFiles changed
webpack/JobWizard/autofill.jswebpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.jsTest plan
cd ~/foreman && npm run test:plugins foreman_remote_execution -- webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.jsdisplay_fqdn_for_hosts = No→ Host Overview → Schedule a job → 1 host selecteddisplay_fqdn_for_hosts = Yes→ same flow, no regressionAssisted by Cursor