Skip to content

Port fluent-ribbon to the vendored upstream gpui (WI-1427) #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thedancingdeveloper wants to merge 1 commit into
base: wi-1426-port-fluent-primitives
Choose a base branch
from
Open

Port fluent-ribbon to the vendored upstream gpui (WI-1427) #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/gpui-api-drift.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,3 +155,4 @@ signature diff. The rows known to matter are called out under "Notes".
|---|---|---|
| `fluent-core` | WI-1425 | No source change. Every symbol it imports is in "unchanged" above, and `cargo check`, `cargo test` (22 unit tests) and `cargo clippy --no-deps -D warnings` pass against `vendor/zed` with the public API untouched. |
| `fluent-primitives` | WI-1426 | Compiles, 27 unit tests pass, `cargo clippy --all-targets --no-deps -D warnings` is clean. The location check above missed five signature changes, all forced by the vendored gpui and each a mechanical adaptation: `Window::focus`, `focus_next` and `focus_prev` now take `&mut App`; `ShapedLine::paint` takes a `TextAlign` and an optional align width (passed `Left` and `None`, the previous implicit behaviour); `Styled::text_style()` returns the refinement directly instead of an `Option`; `ElementId::NamedChild` holds an `Arc` instead of a `Box`; and `Corner` is gone, replaced by `gpui::Anchor`. The crate re-exports its own four-variant `Corner` that converts into `Anchor`, so the popover anchor API the later crates use does not change. |
| `fluent-ribbon` | WI-1427 | No source change. Every gpui symbol it uses (`App`, `AnyElement`, `ClickEvent`, `Context`, `FontWeight`, `IntoElement`, `Render`, `SharedString`, `Window`, `div`, `prelude`, `px`, `svg`) is in "unchanged" above, and `cargo check`, `cargo test` (no unit tests; one ignored doc-test) and `cargo clippy --all-targets --no-deps -D warnings` pass against `vendor/zed` with the public API untouched. |
Loading