Repository navigation
Port fluent-core to the vendored upstream gpui (WI-1425) - #10
Open
thedancingdeveloper wants to merge 1 commit into
Open
thedancingdeveloper wants to merge 1 commit into
thedancingdeveloper wants to merge 1 commit into
Conversation
WI-1425. Every gpui symbol fluent-core imports is unchanged in the vendored snapshot, and check, test (22) and clippy --no-deps -D warnings pass against vendor/zed without touching the crate or its public API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports
crates/fluent-coreto the vendored upstream gpui snapshot ongpui-upstream(WI-1425, phase 1 of the fluent-crate port).Stacked on PR #5 (
gpui-upstream). Do not merge until #5 lands, and not before review.No source change was required. WI-1350's drift report lists every
gpuisymbolfluent-coreimports (Animation,AnimationExt,AnyElement,App,Background,ElementId,Global,Hsla,IntoElement,div,ease_out_quint,hsla,linear_color_stop,linear_gradient,prelude,px,rgb) as unchanged between the base fork and the vendored snapshot, and that holds: the crate compiles, its 22 unit tests pass, and clippy is clean againstvendor/zedwith no edits. This PR only records that indocs/gpui-api-drift.md.fluent-corewas already a workspace member ongpui-upstream(WI-1347 did not drop it), so nothing was re-added.fluent-core's public API. WI-1426..1430 can port against it as-is.Gates (Linux, local, rustc 1.99)
cargo clippy -p fluent-core --all-targets -- -D warnings(with deps) does not pass, but every error is inside the vendored closure (scheduler,ztracing, …), not influent-core. That is pre-existing ongpui-upstreamand is WI-1472's to fix in the base CI; this PR does not touch it.cargo cleanwas run after the gates.Test plan