Skip to content

Application banner - #1284

Merged
jackrhoa merged 16 commits into
devfrom
interest-banner
Sep 3, 2026
Merged

Application banner#1284
jackrhoa merged 16 commits into
devfrom
interest-banner

Conversation

@Adrian-E-V

@Adrian-E-V Adrian-E-V commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Updated site interest banner to reflect application link and deadline.

image

Updated:

  • misc.css
  • _interest_meeting.html

Summary by CodeRabbit

  • New Features

    • Updated the announcement banner to promote applications, including a September 5 deadline.
    • Changed the call-to-action link label to “Application” and directed it to the updated application form.
  • Style

    • Reworked the announcement banner layout to keep the message centered and the close button aligned to the right across supported screen sizes.

@Adrian-E-V
Adrian-E-V requested a review from jackrhoa September 3, 2026 02:40
@Adrian-E-V Adrian-E-V self-assigned this Sep 3, 2026
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

Next included review available in 12 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 1fad2674-ee35-4e34-9b9a-c09c31d66e53

📥 Commits

Reviewing files that changed from the base of the PR and between 6ef7c8d and 044afac.

📒 Files selected for processing (1)
  • tcf_website/templates/site/common/components/_interest_meeting.html

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: b8573eac-709d-4890-af3b-e80aa423c876

📥 Commits

Reviewing files that changed from the base of the PR and between 8f05c71 and 6ef7c8d.

📒 Files selected for processing (2)
  • tcf_website/static/css/site/components/misc.css
  • tcf_website/templates/site/common/components/_interest_meeting.html

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The interest meeting banner now displays an application deadline and links to a new application form. Its layout uses a three-column CSS grid to center the text and right-align the close button.

Changes

Interest Meeting Banner

Layer / File(s) Summary
Update banner content and layout
tcf_website/templates/site/common/components/_interest_meeting.html, tcf_website/static/css/site/components/misc.css
The banner promotes applications by September 5th and links to the new application form. CSS grid centers the text and positions the close button on the right.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 6ef7c

The banner now promotes the application form and deadline while preserving its dismissal behavior and intended centered layout. The change is ready to merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the banner update and lists the modified files, but it omits the required GitHub Issues addressed, What I did, Testing, and Questions/Discussions/Notes sections. It includes o… Use the repository template. Add the issue reference, a What I did section, testing details or reviewer testing steps, and a Questions/Discussions/Notes section. Label the screenshot as Before or After.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title, "Application banner," is concise and accurately identifies the main change: updating the site banner for applications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the banner update and lists the modified files, but it omits the required GitHub Issues addressed, What I did, Testing, and Questions/Discussions/Notes sections. It includes one screenshot but does not identify it as Before or After.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch interest-banner

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jackrhoa

jackrhoa commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

The banner was initially centered on Chrome and Firefox but not Safari for me. Clearing browser cache seemed to fix the issue, hopefully this does not affect our users. Not worth troubleshooting

@@ -4,9 +4,9 @@

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to something like application-2026 so this banner appears for everyone who hid the previous one

@jackrhoa
jackrhoa merged commit 092e477 into dev Sep 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants