895 filter course - #1271
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| if file[0] not in (".", "~") and ".csv" in file: | ||
| self.load_semester_file(file) | ||
| else: | ||
| # TODO: Implement semester-specific loading logic for CourseInstructorSemesterGrade |
There was a problem hiding this comment.
We only load all semesters at once so this isn't necessary (and the logic would be the same)
|
We currently don't have the data for certain January / Summer sessions, so the loading would fail as currently written. Working on scraping that now. |
#1277 resolved this. |
| term_year, term_season = row["Term Desc"].split() | ||
| semester_id = self.semesters.get((int(term_year), term_season.upper())) | ||
| if semester_id is None: | ||
| raise ValueError( |
There was a problem hiding this comment.
The script should not completely stop mid-load if a grade data csv does not have corresponding course data from that semester
2 participants
GitHub Issues addressed
What I did
CourseSemesterInstructorGrade. This table is very similar toCourseInstructorGrade, but breaks down course/instructors by semesterCourseSemesterInstructorGradePR is in progress.