fix(renovate): say the two things a fork has to say - #35
Merged
Merged
Conversation
Renovate has access to this repository, its config is on `main`, and
`renovate-config-validator` passes on it — and across two scheduled Mondays it
had opened nothing at all: no pull request, no dependency dashboard, no config
warning. A weekly schedule makes that indistinguishable from a healthy quiet
week, which is how it went unnoticed.
Two defaults were deciding this silently, and both are now written out:
- `forkProcessing: 'enabled'`. This repository is a fork, and Renovate's
`'auto'` default decides for itself whether to process one. It is the single
condition here that is specific to being a fork, and saying it outright
costs nothing.
- `dependencyDashboard: true`, rather than inheriting it from
`config:recommended`. The dashboard is the only surface that shows what
Renovate is holding back, the only checkbox that forces a run off schedule,
and — with a weekly schedule — the only thing that distinguishes a running
app from an absent one on a Tuesday. Issues are enabled on the repository
now, so it has somewhere to appear.
`CLAUDE.md` claimed the app was installed and that a quiet week was expected
rather than a symptom. Both sentences were load-bearing and one of them was
wrong, so the section now carries what was measured, the order to check things
in when the stream goes quiet, and the one thing a shell cannot check.
What the quiet has cost is not hypothetical: `bun scripts/audit-check.ts` passes
because nothing is high or critical, while 20 advisories sit open in the tree —
ten in `hono`, several of those cross-request leaks. All transitive, which is
the class `lockFileMaintenance` exists for and the class GitHub's dependency
graph cannot see, because it does not parse `bun.lock`.
Nothing in the running service changes.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Renovate has access to this repository,
.github/renovate.json5is onmain, andrenovate-config-validatorpasses on it. Across two scheduled Mondays it had opened nothing: no pull request, no dependency dashboard, no config warning.With
schedule: ['before 6am on monday'], that is indistinguishable from a healthy quiet week — which is exactly whatCLAUDE.mdtold the reader to expect.renovate[bot].github/renovate.json5onmainrenovate-config-validatorWhat changes
Two defaults were deciding this silently. Both are now written out in the config:
forkProcessing: 'enabled'— this repository is a fork ofQuackbackIO/quackback, and Renovate's'auto'default decides for itself whether to process one. It is the single condition here specific to being a fork.dependencyDashboard: true— rather than inheriting it fromconfig:recommended. It is the only surface showing what Renovate is holding back, the only checkbox that forces a run off schedule, and the only thing that tells a running app from an absent one on a non-Monday.Neither changes what Renovate would do if it were already running. They remove the two ways it can do nothing without saying so.
The documentation was the other half of the bug
CLAUDE.mdasserted the app was installed and that "a quiet week is expected rather than a symptom". Both sentences were load-bearing and one of them was wrong. The section now carries what was measured, the order to check things in when the stream goes quiet — dashboard exists, config validates, config is on the default branch — and the one thing a shell cannot check: the installation itself needs an app-authorized token, and GitHub Apps do not appear underrepos/.../hooks.What the quiet cost
bun scripts/audit-check.tspasses, because nothing is high or critical. Twenty advisories are open in the tree:hono×10 — includinghono/jsxnot isolating context per request andmemo()retaining SSR output across requests (both cross-user leaks), plus ReDoS in the CORS and language middlewareqs×3 (DoS),uuid,fast-xml-parser,@hono/node-server,body-parser,esbuild,@babel/coreAll transitive — the class
lockFileMaintenanceexists for, and the class GitHub's dependency graph cannot see, because it does not parsebun.lock.Gates
Config-only and documentation-only.
renovate-config-validatorpasses on the edited file; prettier clean. Nothing in the running service changes.🤖 Generated with Claude Code