Conversation
Closes #158 The 'Pinned' header and its drop placeholder are always rendered, so users who never pin a tab still see a permanent empty block plus a divider between favorites and the tab list. The section is now built only when there are pinned tabs or a drag is in progress, so the drop target still appears exactly when it is actionable. The divider follows the same rule. Also tightens the sidebar spacing (16 -> 8) and the pinned list spacing (8 -> 4) now that the empty block no longer separates them.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #158
Problem
The
Pinnedheader and its dashed drop placeholder are rendered unconditionally, so anyone who never pins a tab sees a permanent empty block in the sidebar, plus aDivider()separating it from the tab list. Issue #158 asks for exactly this.Change
PinnedTabsListbuilds its header and placeholder only when there are pinned tabs or a drag is in progress, so the drop target still appears precisely when it is actionable.ContainerViewskips the whole section under the same condition, and the divider follows it.With the empty block gone the surrounding spacing was too loose, so sidebar spacing goes 16 -> 8 and the pinned list 8 -> 4.
Testing
Built Release on macOS 26.2. Verified: with zero pinned tabs the section is gone and favorites sit directly above the tab list; dragging a tab makes the placeholder appear and it accepts the drop; with pinned tabs present header, list and divider render as before.