Skip to content

Calculator Code Review #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kunikazu723 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Calculator Code Review #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
113 changes: 113 additions & 0 deletions Calculator.Kunikazu723/CalculatorLibrary/CalculatorLibrary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,113 @@
using System.Diagnostics;
using Newtonsoft.Json;
namespace CalculatorLibrary
{
public class Calculator
{
JsonWriter _writer;

public Calculator()
{
StreamWriter logFile = File.CreateText("calcuator.json");
logFile.AutoFlush = true;

_writer = new JsonTextWriter(logFile);
_writer.Formatting = Formatting.Indented;
_writer.WriteStartObject();
_writer.WritePropertyName("Operations");
_writer.WriteStartArray();
}
public double DoOperation(double num1, double num2, string op)
{
double result = double.NaN; // Default value is "not-a-number" if an operation, such as division, could result in an error.

_writer.WriteStartObject();

_writer.WritePropertyName("Operand1");
_writer.WriteValue(num1);

_writer.WritePropertyName("Operand2");
_writer.WriteValue(num2);

double radians = num1 * (Math.PI / 180.00);


char symbol = ' ';
// Use a switch statement to do the math.
switch (op)
{
case "a":
result = num1 + num2;
symbol = '+';
break;
case "s":
result = num1 - num2;
symbol = '-';
break;
case "m":
result = num1 * num2;
symbol = '*';
break;
case "d":
// Ask the user to enter a non-zero divisor.
if (num2 != 0)
{
result = num1 / num2;
symbol = '/';
}
break;
case "sqrt":
result = Math.Sqrt(num1);
symbol = '√';
break;
case "pow":
result = Math.Pow(num1, num2);
symbol = '^';
break;
case "10x":
result = Math.Pow(10, num1);
symbol = 'E';
break;
case "sin":
result = Math.Sin(radians);
symbol = 'S';
break;
case "cos":
result = Math.Cos(radians);
symbol = 'C';
break;
case "tg":
if (num1 == 90)
{
Console.WriteLine("Undefined");
result = 0;
}
else
{
result = Math.Tan(radians);
symbol = 'T';
}
break;
// Return text for an incorrect option entry.
default:
break;
}
_writer.WritePropertyName("Operation");
_writer.WriteValue(symbol);
_writer.WritePropertyName("Result");
_writer.WriteValue(result);
_writer.WriteEndObject();

Trace.WriteLine($"{num1} {symbol} {(double.IsNaN(num2) ? "" : num2)} = {result}");

return result;
}

public void Finish()
{
_writer.WriteEndArray();
_writer.WriteEndObject();
_writer.Close();
}
}
}
13 changes: 13 additions & 0 deletions Calculator.Kunikazu723/CalculatorLibrary/CalculatorLibrary.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net9.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="13.0.4" />
</ItemGroup>

</Project>
17 changes: 17 additions & 0 deletions Calculator.Kunikazu723/SimpleCalculator/Calculation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace SimpleCalculator
{
internal class Calculation
{
public double Operand1 { get; init; }
public double Operand2 { get; init; }
public double Result { get; init; }
public string Operation { get; init; } = string.Empty;

}
}
213 changes: 213 additions & 0 deletions Calculator.Kunikazu723/SimpleCalculator/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,213 @@
using System.ComponentModel;
using System.Text.RegularExpressions;
using CalculatorLibrary;
namespace SimpleCalculator
{
class Program
{
static void Main(string[] args)
{
var calculations = new List<Calculation>();
var calculator = new Calculator();
CalculatorInterface(calculations, calculator);
calculator.Finish();
return;
}

static void CalculatorInterface(List<Calculation> calculations, Calculator calculator)
{
while (true)
{
// Display title as the C# console calculator app.
Console.WriteLine("Console Calculator in C#\r");
Console.WriteLine("------------------------\n");
Console.WriteLine($"Total Calculations Performed {calculations.Count}");

Console.WriteLine("What do you want to do?");
Console.WriteLine("\tc - Calculator");
Console.WriteLine("\ts - See previous results");
Console.WriteLine("\tdel - Delete all previous results");

string? userChoice = Console.ReadLine();
if (userChoice is null)
{
Console.WriteLine("Error: Option is null");
continue;
}

switch (userChoice)
{
case "c":
CalculatorLoop(calculator, calculations);
break;
case "s":
if (calculations.Count == 0) Console.WriteLine("No calculations available");
else
{
for (int i = 0; i < calculations.Count; i++)
{
Console.WriteLine($"[{i}] -> Type {calculations[i].Operation}: {calculations[i].Operand1} and {calculations[i].Operand2} = {calculations[i].Result}");
}

Console.WriteLine("Select a result from the previous list: ");
string? chosenResultIndex = Console.ReadLine();
int chosenResultIndexClean;
if (chosenResultIndex is null || !int.TryParse(chosenResultIndex, out chosenResultIndexClean) || chosenResultIndexClean > calculations.Count - 1)
{
Console.WriteLine("Invalid index");
continue;
}

CalculatorLoop(calculator, calculations, calculations[chosenResultIndexClean].Result);
}
break;
case "del":
Console.WriteLine("Deleting All History of Calculations");
calculations.Clear();
break;
default:
Console.WriteLine("Invalid Option");
break;
}

}


}



private static void CalculatorLoop(Calculator calculator, List<Calculation> calculations, double previousResult = double.NaN)
{
bool endApp = false;
int calculatorUses = calculations.Count();


while (!endApp)
{
// Declare variables and set to empty.
// Use Nullable types (with ?) to match type of System.Console.ReadLine
Console.Clear();
string? numInput1 = "";
string? numInput2 = "";
double result = 0;
// Ask the user to type the first number.
double cleanNum1;
if (double.IsNaN(previousResult))
{
Console.Write("Type a number, and then press Enter: ");
Console.WriteLine("For trig functions, input the angle in degrees");

numInput1 = Console.ReadLine();

cleanNum1 = 0;
while (!double.TryParse(numInput1, out cleanNum1))
{
Console.Write("This is not valid input. Please enter a numeric value: ");
numInput1 = Console.ReadLine();
}

}
else
{
endApp = true;
Console.WriteLine($"Using {previousResult} as Operand 1");
cleanNum1 = previousResult;
}


// Ask the user to choose an operator.
Console.WriteLine("Choose an operator from the following list:");
Console.WriteLine("\ta - Add");
Console.WriteLine("\ts - Subtract");
Console.WriteLine("\tm - Multiply");
Console.WriteLine("\td - Divide");
Console.WriteLine("\tsqrt - Square Root");
Console.WriteLine("\tpow - Exopnent");
Console.WriteLine("\t10x - Power of 10");
Console.WriteLine("\tsin - Sine");
Console.WriteLine("\tcos - Cosine");
Console.WriteLine("\ttg - Tangent");
Console.Write("Your option? ");

string? op = Console.ReadLine();

// Ask the user to type the second number.
double cleanNum2 = double.NaN;
if (op is null || !Regex.IsMatch(op, "^(a|s|m|d|sqrt|pow|10x|sin|cos|tg)$"))
{
Console.WriteLine("Error Invalid Input");
continue;
}
else if (!Regex.IsMatch(op, "^(sqrt|10x|sin|cos|tg)$"))
{
Console.Write("Type another number, and then press Enter: ");
numInput2 = Console.ReadLine();

cleanNum2 = 0;
while (!double.TryParse(numInput2, out cleanNum2))
{
Console.Write("This is not valid input. Please enter a numeric value: ");
numInput2 = Console.ReadLine();
}
}

// Validate input is not null, and matches the pattern
try
{
result = calculator.DoOperation(cleanNum1, cleanNum2, op);
if (double.IsNaN(result))
{
Console.WriteLine("This operation will result in a mathematical error.\n");
}
else
{
Console.WriteLine("Your result: {0:0.##}\n", result);
string operation = op switch
{
"a" => "Add",
"s" => "Subtract",
"m" => "Multiply",
"d" => "Divide",
"sqrt" => "Square Root",
"pow" => "Exponentiation",
"10x" => "Power of 10",
"sin" => "Sine",
"cos" => "Cosine",
"tg" => "Tangent",
_ => throw new ArgumentException()
};

calculations.Add(
new Calculation()
{
Operand1 = cleanNum1,
Operand2 = cleanNum2,
Result = result,
Operation = operation
}
);
calculatorUses = calculations.Count();
}
}
catch (Exception e)
{
Console.WriteLine("Oh no! An exception occurred trying to do the math.\n - Details: " + e.Message);
}

Console.WriteLine("------------------------\n");

// Wait for the user to respond before closing.

string finalMessage = endApp ? "Press Any Key To Continue" : "Press 'n' and Enter to close the app, or press any other key and Enter to continue: ";
Console.Write(finalMessage);
if (Console.ReadLine() == "n") endApp = true;

Console.WriteLine("\n"); // Friendly linespacing.
}

return;
}
}

}
14 changes: 14 additions & 0 deletions Calculator.Kunikazu723/SimpleCalculator/SimpleCalculator.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net9.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\CalculatorLibrary\CalculatorLibrary.csproj" />
</ItemGroup>

</Project>
Loading
Loading