Repository navigation
Replace the unknown object icon with UTTypeItem - #170
Merged
dayglojesus merged 1 commit intoOct 27, 2026
Merged
Conversation
Three places drew the HFS unknown object icon through the deprecated
-[NSWorkspace iconForFileType:]: the file browser row of a document
that is not on disk, the Find dialog folder menus, and the tab overflow
menu. No UTType reproduces that icon, so the placeholder changes.
UTTypeItem is the system document icon with a question mark. It says
"not a file on disk", as the dashed placeholder did, and it stays
visible in light and dark appearance, where the old icon is almost
invisible. The choice was made on #158.
Recompiling the three files gives 0 deprecation warnings, from 3 on
main.
Fix #158
Written by Claude Sonnet 5.5 (claude-sonnet-5-5)
Reviewed by Claude Opus 5.5 (claude-opus-5-5)
Reviewed by Claude Fable 5.1 (claude-fable-5-1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the HFS unknown object icon with the system "item" document icon, as chosen on #158.
Change
Three places drew
kUnknownFSObjectIconthrough the deprecated-[NSWorkspace iconForFileType:]. Each now uses[NSWorkspace.sharedWorkspace iconForContentType:UTTypeItem]:FileItemImage.mmNSMenuItem Additions.mm-setIconForFile:for a path that does not exist and has no extensionOakTabBarView.mmThe icon changes on purpose: no
UTTypereproduces the dashed placeholder. The new one is the system document with a "?", visible in both appearances.Evidence
Recompiling the three files: 3 deprecation warnings on
main, 0 here.ninja -C build TextMatepasses.Captures from the real code paths (
CreateIconImageForURLand-[NSMenuItem setIconForFile:]), actual size and 4x:main)Not covered
The tab overflow menu of untitled tabs showed no icon in any build on macOS 27, so there is no in-app capture of that site. It uses the same expression as the other two.
Fix #158
🤖 Generated with Claude Code